HDFS-17850. Reject append when new generation stamp equals or is less… by deepujain · Pull Request #8334 · apache/hadoop

deepujain · 2026-03-09T15:41:52Z

Summary

When using a third-party HDFS client, if the client does not update the generation stamp (GS) correctly on append, the DataNode previously accepted newGS == currentGS, which can lead to corrupted replica state. This change requires the new generation stamp to be strictly greater than the replica's current generation stamp: append now rejects both newGS < currentGS (existing) and newGS == currentGS (new), so misbehaving clients cannot silently corrupt replica state.

Change

FsDatasetImpl.java: In append(ExtendedBlock b, long newGS, long expectedBlockLen), change the validity check from newGS < b.getGenerationStamp() to newGS <= b.getGenerationStamp(), so that equal generation stamps are also rejected with the same IOException message.
TestFsDatasetImpl.java: Add testAppendRejectsSameOrLowerGenerationStamp(): create a file, get the finalized block, then assert that append(block, block.getGenerationStamp(), blockLen) and append(block, block.getGenerationStamp() - 1, blockLen) throw IOException with "should be greater than the replica", and that append(block, block.getGenerationStamp() + 1, blockLen) succeeds (HDFS-17850).

JIRA

Fixes HDFS-17850

hadoop-yetus · 2026-03-10T13:33:24Z

🎊 +1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	0m 34s		Docker mode activated.
			_ Prechecks _
+1 💚	dupname	0m 0s		No case conflicting files found.
+0 🆗	codespell	0m 1s		codespell was not available.
+0 🆗	detsecrets	0m 1s		detect-secrets was not available.
+1 💚	@author	0m 0s		The patch does not contain any @author tags.
+1 💚	test4tests	0m 0s		The patch appears to include 1 new or modified test files.
			_ trunk Compile Tests _
+1 💚	mvninstall	40m 20s		trunk passed
+1 💚	compile	1m 45s		trunk passed with JDK Ubuntu-21.0.10+7-Ubuntu-124.04
+1 💚	compile	1m 50s		trunk passed with JDK Ubuntu-17.0.18+8-Ubuntu-124.04.1
+1 💚	checkstyle	1m 45s		trunk passed
+1 💚	mvnsite	1m 58s		trunk passed
+1 💚	javadoc	1m 31s		trunk passed with JDK Ubuntu-21.0.10+7-Ubuntu-124.04
+1 💚	javadoc	1m 32s		trunk passed with JDK Ubuntu-17.0.18+8-Ubuntu-124.04.1
+1 💚	spotbugs	4m 9s		trunk passed
+1 💚	shadedclient	30m 46s		branch has no errors when building and testing our client artifacts.
			_ Patch Compile Tests _
+1 💚	mvninstall	1m 20s		the patch passed
+1 💚	compile	1m 14s		the patch passed with JDK Ubuntu-21.0.10+7-Ubuntu-124.04
+1 💚	javac	1m 14s		the patch passed
+1 💚	compile	1m 17s		the patch passed with JDK Ubuntu-17.0.18+8-Ubuntu-124.04.1
+1 💚	javac	1m 17s		the patch passed
+1 💚	blanks	0m 0s		The patch has no blanks issues.
+1 💚	checkstyle	1m 17s		the patch passed
+1 💚	mvnsite	1m 26s		the patch passed
+1 💚	javadoc	0m 58s		the patch passed with JDK Ubuntu-21.0.10+7-Ubuntu-124.04
+1 💚	javadoc	1m 2s		the patch passed with JDK Ubuntu-17.0.18+8-Ubuntu-124.04.1
+1 💚	spotbugs	3m 52s		the patch passed
+1 💚	shadedclient	30m 10s		patch has no errors when building and testing our client artifacts.
			_ Other Tests _
+1 💚	unit	217m 50s		hadoop-hdfs in the patch passed.
+1 💚	asflicense	0m 45s		The patch does not generate ASF License warnings.
		345m 19s

Subsystem	Report/Notes
Docker	ClientAPI=1.54 ServerAPI=1.54 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-8334/1/artifact/out/Dockerfile
GITHUB PR	#8334
Optional Tests	dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets
uname	Linux 312fb1560ce1 5.15.0-164-generic #174-Ubuntu SMP Fri Nov 14 20:25:16 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/bin/hadoop.sh
git revision	trunk / `b40483d`
Default Java	Ubuntu-17.0.18+8-Ubuntu-124.04.1
Multi-JDK versions	/usr/lib/jvm/java-21-openjdk-amd64:Ubuntu-21.0.10+7-Ubuntu-124.04 /usr/lib/jvm/java-17-openjdk-amd64:Ubuntu-17.0.18+8-Ubuntu-124.04.1
Test Results	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-8334/1/testReport/
Max. process+thread count	3473 (vs. ulimit of 5500)
modules	C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs
Console output	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-8334/1/console
versions	git=2.43.0 maven=3.9.11 spotbugs=4.9.7
Powered by	Apache Yetus 0.14.1 https://yetus.apache.org

This message was automatically generated.

deepujain · 2026-05-27T15:59:50Z

CI is green on the current head, and this one still has not had a human review. @Hexiaoqiao @ZanderXu, when you have a moment, could you please take a look? Happy to make any follow-up changes.

deepujain · 2026-06-14T16:17:41Z

CI is still green on the current head, and this one is still waiting on human review. @hfutatzhanghb @Hexiaoqiao, when you have a moment, could you please take a look? Happy to make any follow-up changes.

hfutatzhanghb · 2026-06-15T05:46:23Z

@deepujain Thanks for your work! Could you rebase this PR onto the latest trunk branch ? Will review later. Thanks.

deepujain · 2026-06-15T07:07:51Z

Rebased this onto the latest apache/trunk and force-pushed the refreshed single commit. Local validation passed with JAVA_HOME=/opt/homebrew/opt/openjdk@17/libexec/openjdk.jdk/Contents/Home ./mvnw -Dmaven.repo.local=/tmp/codex-m2 test -pl hadoop-hdfs-project/hadoop-hdfs -am -Dtest=TestFsDatasetImpl -DskipTests=false. Ready for review whenever you get a chance.

hadoop-yetus · 2026-06-15T11:37:49Z

🎊 +1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	6m 35s		Docker mode activated.
			_ Prechecks _
+1 💚	dupname	0m 0s		No case conflicting files found.
+0 🆗	codespell	0m 1s		codespell was not available.
+0 🆗	detsecrets	0m 1s		detect-secrets was not available.
+1 💚	@author	0m 0s		The patch does not contain any @author tags.
+1 💚	test4tests	0m 0s		The patch appears to include 1 new or modified test files.
			_ trunk Compile Tests _
+1 💚	mvninstall	26m 30s		trunk passed
+1 💚	compile	0m 57s		trunk passed with JDK Ubuntu-21.0.11+10-1-24.04.2-Ubuntu
+1 💚	compile	1m 0s		trunk passed with JDK Ubuntu-17.0.19+10-1-24.04.2-Ubuntu
+1 💚	checkstyle	0m 58s		trunk passed
+1 💚	mvnsite	1m 5s		trunk passed
+1 💚	javadoc	0m 47s		trunk passed with JDK Ubuntu-21.0.11+10-1-24.04.2-Ubuntu
+1 💚	javadoc	0m 49s		trunk passed with JDK Ubuntu-17.0.19+10-1-24.04.2-Ubuntu
+1 💚	spotbugs	2m 8s		trunk passed
+1 💚	shadedclient	18m 9s		branch has no errors when building and testing our client artifacts.
			_ Patch Compile Tests _
+1 💚	mvninstall	0m 45s		the patch passed
+1 💚	compile	0m 39s		the patch passed with JDK Ubuntu-21.0.11+10-1-24.04.2-Ubuntu
+1 💚	javac	0m 39s		the patch passed
+1 💚	compile	0m 40s		the patch passed with JDK Ubuntu-17.0.19+10-1-24.04.2-Ubuntu
+1 💚	javac	0m 40s		the patch passed
+1 💚	blanks	0m 0s		The patch has no blanks issues.
+1 💚	checkstyle	0m 39s		the patch passed
+1 💚	mvnsite	0m 45s		the patch passed
+1 💚	javadoc	0m 33s		the patch passed with JDK Ubuntu-21.0.11+10-1-24.04.2-Ubuntu
+1 💚	javadoc	0m 37s		the patch passed with JDK Ubuntu-17.0.19+10-1-24.04.2-Ubuntu
+1 💚	spotbugs	2m 3s		the patch passed
+1 💚	shadedclient	18m 29s		patch has no errors when building and testing our client artifacts.
			_ Other Tests _
+1 💚	unit	185m 1s		hadoop-hdfs in the patch passed.
+1 💚	asflicense	0m 30s		The patch does not generate ASF License warnings.
		269m 8s

Subsystem	Report/Notes
Docker	ClientAPI=1.54 ServerAPI=1.54 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-8334/2/artifact/out/Dockerfile
GITHUB PR	#8334
Optional Tests	dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets
uname	Linux af2380a1079e 5.15.0-181-generic #191-Ubuntu SMP Fri May 22 19:09:02 UTC 2026 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/bin/hadoop.sh
git revision	trunk / `261c748`
Default Java	Ubuntu-17.0.19+10-1-24.04.2-Ubuntu
Multi-JDK versions	/usr/lib/jvm/java-21-openjdk-amd64:Ubuntu-21.0.11+10-1-24.04.2-Ubuntu /usr/lib/jvm/java-17-openjdk-amd64:Ubuntu-17.0.19+10-1-24.04.2-Ubuntu
Test Results	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-8334/2/testReport/
Max. process+thread count	4193 (vs. ulimit of 10000)
modules	C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs
Console output	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-8334/2/console
versions	git=2.43.0 maven=3.9.15 spotbugs=4.9.7
Powered by	Apache Yetus 0.14.1 https://yetus.apache.org

This message was automatically generated.

deepujain · 2026-06-26T15:00:15Z

The rebase request is addressed and CI is green on the current head. @hfutatzhanghb, when you have a moment, could you please take another look? Happy to make any follow-up changes.

deepujain · 2026-07-06T10:36:46Z

The requested rebase is already addressed and CI is still green on the current head. @hfutatzhanghb, when you have a moment, could you please take another look? Happy to make any follow-up changes.

deepujain · 2026-07-09T07:54:04Z

Rebased this on current trunk and force-pushed the refreshed head. Ran JAVA_HOME=/opt/homebrew/opt/openjdk@17/libexec/openjdk.jdk/Contents/Home PATH=/opt/homebrew/opt/openjdk@17/libexec/openjdk.jdk/Contents/Home/bin:$PATH ./mvnw test -pl hadoop-hdfs-project/hadoop-hdfs -am -Dtest=TestFsDatasetImpl -DskipTests=false -Dmaven.repo.local=/private/tmp/hadoop-m2 locally, and it passed. Ready for another look.

hadoop-yetus · 2026-07-09T12:13:32Z

🎊 +1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	0m 21s		Docker mode activated.
			_ Prechecks _
+1 💚	dupname	0m 0s		No case conflicting files found.
+0 🆗	codespell	0m 0s		codespell was not available.
+0 🆗	detsecrets	0m 0s		detect-secrets was not available.
+1 💚	@author	0m 0s		The patch does not contain any @author tags.
+1 💚	test4tests	0m 0s		The patch appears to include 1 new or modified test files.
			_ trunk Compile Tests _
+1 💚	mvninstall	26m 25s		trunk passed
+1 💚	compile	1m 0s		trunk passed with JDK Ubuntu-21.0.11+10-1-24.04.2-Ubuntu
+1 💚	compile	1m 0s		trunk passed with JDK Ubuntu-17.0.19+10-1-24.04.2-Ubuntu
+1 💚	checkstyle	1m 5s		trunk passed
+1 💚	mvnsite	1m 8s		trunk passed
+1 💚	javadoc	0m 57s		trunk passed with JDK Ubuntu-21.0.11+10-1-24.04.2-Ubuntu
+1 💚	javadoc	0m 57s		trunk passed with JDK Ubuntu-17.0.19+10-1-24.04.2-Ubuntu
+1 💚	spotbugs	2m 18s		trunk passed
+1 💚	shadedclient	17m 30s		branch has no errors when building and testing our client artifacts.
			_ Patch Compile Tests _
+1 💚	mvninstall	0m 44s		the patch passed
+1 💚	compile	0m 41s		the patch passed with JDK Ubuntu-21.0.11+10-1-24.04.2-Ubuntu
+1 💚	javac	0m 41s		the patch passed
+1 💚	compile	0m 44s		the patch passed with JDK Ubuntu-17.0.19+10-1-24.04.2-Ubuntu
+1 💚	javac	0m 44s		the patch passed
+1 💚	blanks	0m 0s		The patch has no blanks issues.
+1 💚	checkstyle	0m 41s		the patch passed
+1 💚	mvnsite	0m 46s		the patch passed
+1 💚	javadoc	0m 38s		the patch passed with JDK Ubuntu-21.0.11+10-1-24.04.2-Ubuntu
+1 💚	javadoc	0m 36s		the patch passed with JDK Ubuntu-17.0.19+10-1-24.04.2-Ubuntu
+1 💚	spotbugs	2m 1s		the patch passed
+1 💚	shadedclient	16m 43s		patch has no errors when building and testing our client artifacts.
			_ Other Tests _
+1 💚	unit	182m 57s		hadoop-hdfs in the patch passed.
+1 💚	asflicense	0m 31s		The patch does not generate ASF License warnings.
		259m 12s

Subsystem	Report/Notes
Docker	ClientAPI=1.55 ServerAPI=1.55 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-8334/3/artifact/out/Dockerfile
GITHUB PR	#8334
Optional Tests	dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets
uname	Linux 3b75c4585723 5.15.0-181-generic #191-Ubuntu SMP Fri May 22 19:09:02 UTC 2026 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/bin/hadoop.sh
git revision	trunk / `2f536d1`
Default Java	Ubuntu-17.0.19+10-1-24.04.2-Ubuntu
Multi-JDK versions	/usr/lib/jvm/java-21-openjdk-amd64:Ubuntu-21.0.11+10-1-24.04.2-Ubuntu /usr/lib/jvm/java-17-openjdk-amd64:Ubuntu-17.0.19+10-1-24.04.2-Ubuntu
Test Results	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-8334/3/testReport/
Max. process+thread count	4433 (vs. ulimit of 10000)
modules	C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs
Console output	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-8334/3/console
versions	git=2.43.0 maven=3.9.15 spotbugs=4.9.7
Powered by	Apache Yetus 0.14.1 https://yetus.apache.org

This message was automatically generated.

deepujain · 2026-07-09T23:48:37Z

Reran the existing Build workflow on the current head. No code changes here. The previous GitHub Build failure was in the unrelated TestDSWithMultipleNodeManager shard, while Apache Yetus and pr-merge on this head are already green.

deepujain · 2026-07-10T03:05:20Z

Reran the existing workflow on the current head again. The latest fork-side rerun hit the shared lane, while and on this head are green. No code changes in this update.

deepujain · 2026-07-10T03:05:34Z

Reran the existing Build workflow on the current head again. The latest fork-side rerun hit the shared Run / Test hdfs-rbf (Java 17) ubuntu_24-trunk lane, while Apache Yetus and pr-merge on this head are green. No code changes in this update.

deepujain · 2026-07-11T03:40:08Z

No code changes here. I reran the existing fork-side Build workflow on the current head again, so the stale red GitHub Actions lane is being refreshed now.

hadoop-yetus · 2026-07-11T08:18:55Z

🎊 +1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	0m 21s		Docker mode activated.
			_ Prechecks _
+1 💚	dupname	0m 0s		No case conflicting files found.
+0 🆗	codespell	0m 0s		codespell was not available.
+0 🆗	detsecrets	0m 0s		detect-secrets was not available.
+1 💚	@author	0m 0s		The patch does not contain any @author tags.
+1 💚	test4tests	0m 0s		The patch appears to include 1 new or modified test files.
			_ trunk Compile Tests _
+1 💚	mvninstall	26m 35s		trunk passed
+1 💚	compile	0m 59s		trunk passed with JDK Ubuntu-21.0.11+10-1-24.04.2-Ubuntu
+1 💚	compile	1m 2s		trunk passed with JDK Ubuntu-17.0.19+10-1-24.04.2-Ubuntu
+1 💚	checkstyle	0m 56s		trunk passed
+1 💚	mvnsite	1m 5s		trunk passed
+1 💚	javadoc	0m 48s		trunk passed with JDK Ubuntu-21.0.11+10-1-24.04.2-Ubuntu
+1 💚	javadoc	0m 57s		trunk passed with JDK Ubuntu-17.0.19+10-1-24.04.2-Ubuntu
+1 💚	spotbugs	2m 13s		trunk passed
+1 💚	shadedclient	17m 11s		branch has no errors when building and testing our client artifacts.
			_ Patch Compile Tests _
+1 💚	mvninstall	0m 44s		the patch passed
+1 💚	compile	0m 42s		the patch passed with JDK Ubuntu-21.0.11+10-1-24.04.2-Ubuntu
+1 💚	javac	0m 42s		the patch passed
+1 💚	compile	0m 45s		the patch passed with JDK Ubuntu-17.0.19+10-1-24.04.2-Ubuntu
+1 💚	javac	0m 45s		the patch passed
+1 💚	blanks	0m 0s		The patch has no blanks issues.
+1 💚	checkstyle	0m 42s		the patch passed
+1 💚	mvnsite	0m 50s		the patch passed
+1 💚	javadoc	0m 34s		the patch passed with JDK Ubuntu-21.0.11+10-1-24.04.2-Ubuntu
+1 💚	javadoc	0m 37s		the patch passed with JDK Ubuntu-17.0.19+10-1-24.04.2-Ubuntu
+1 💚	spotbugs	2m 0s		the patch passed
+1 💚	shadedclient	16m 25s		patch has no errors when building and testing our client artifacts.
			_ Other Tests _
+1 💚	unit	183m 33s		hadoop-hdfs in the patch passed.
+1 💚	asflicense	0m 28s		The patch does not generate ASF License warnings.
		259m 7s

Subsystem	Report/Notes
Docker	ClientAPI=1.55 ServerAPI=1.55 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-8334/4/artifact/out/Dockerfile
GITHUB PR	#8334
Optional Tests	dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets
uname	Linux 134707958de6 5.15.0-181-generic #191-Ubuntu SMP Fri May 22 19:09:02 UTC 2026 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/bin/hadoop.sh
git revision	trunk / `39d8560`
Default Java	Ubuntu-17.0.19+10-1-24.04.2-Ubuntu
Multi-JDK versions	/usr/lib/jvm/java-21-openjdk-amd64:Ubuntu-21.0.11+10-1-24.04.2-Ubuntu /usr/lib/jvm/java-17-openjdk-amd64:Ubuntu-17.0.19+10-1-24.04.2-Ubuntu
Test Results	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-8334/4/testReport/
Max. process+thread count	3871 (vs. ulimit of 10000)
modules	C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs
Console output	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-8334/4/console
versions	git=2.43.0 maven=3.9.15 spotbugs=4.9.7
Powered by	Apache Yetus 0.14.1 https://yetus.apache.org

This message was automatically generated.

deepujain · 2026-07-13T00:32:37Z

No code changes here. I reran the current head again on July 12, 2026 to refresh the fork-side red GitHub Actions lane. On that rerun, the only failing shard was Run / Test hdfs-rbf (Java 17) ubuntu_24-trunk, where Surefire reported a forked-VM crash around org.apache.hadoop.hdfs.server.federation.security.token.TestZKDelegationTokenSecretManagerImpl. Apache Yetus and pr-merge on this head are already green.

If the patch looks reasonable, @hfutatzhanghb @Hexiaoqiao, could you please take a look when you have a moment? Happy to make any follow-up changes.

deepujain · 2026-07-20T11:33:21Z

No code changes here. Apache Yetus and pr-merge on this head are still green, and this one is still waiting on human review as of July 20, 2026. @hfutatzhanghb @Hexiaoqiao, when you have a moment, could you please take a look? Happy to make any follow-up changes.

deepujain · 2026-07-21T07:19:20Z

No code changes here. I reran the existing fork-side Build workflow on the current head again on July 21, 2026, so the stale red GitHub Actions lane is being refreshed now.

deepujain · 2026-07-21T13:56:15Z

No code changes here. I reran the fork-side Build workflow on July 21, 2026, and the rerun still failed in the shared Run / Test hdfs-rbf (Java 17) ubuntu_24-trunk lane, specifically org.apache.hadoop.yarn.applications.distributedshell.TestDSWithMultipleNodeManager. That still looks outside this HDFS append-generation-stamp patch.

deepujain · 2026-07-26T05:06:58Z

No code changes here. Apache Yetus and pr-merge on this head are still green, and the remaining red GitHub Actions lane is still the unrelated shared failure path already called out on July 21, 2026. If the patch itself looks good, @hfutatzhanghb @Hexiaoqiao, could you please take another look when you have a moment? Happy to make any follow-up changes.

… than replica.

deepujain · 2026-08-04T13:27:57Z

Rebased this branch onto current apache/trunk on August 4, 2026 and force-pushed the refreshed single commit. I also retried JAVA_HOME=/opt/homebrew/opt/openjdk@17/libexec/openjdk.jdk/Contents/Home PATH=/opt/homebrew/opt/openjdk@17/libexec/openjdk.jdk/Contents/Home/bin:$PATH ./mvnw -Dmaven.repo.local=/private/tmp/hadoop-m2 test -pl hadoop-hdfs-project/hadoop-hdfs -am -Dtest=TestFsDatasetImpl -DskipTests=false on the rebased head, but it timed out in this environment during the long reactor rebuild before it reached a test result. No source changes beyond the rebase in this update.

deepujain · 2026-08-05T05:24:12Z

Pushed a no-code Trigger CI commit on August 5, 2026 to refresh the stale pending checks on the current head. The previous fork-side GitHub Build had already passed, so this update is only to give continuous-integration/jenkins/pr-merge and the Apache-side check view a fresh event.

hadoop-yetus · 2026-08-05T09:41:49Z

💔 -1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	0m 22s		Docker mode activated.
			_ Prechecks _
+1 💚	dupname	0m 0s		No case conflicting files found.
+0 🆗	codespell	0m 0s		codespell was not available.
+0 🆗	detsecrets	0m 0s		detect-secrets was not available.
+1 💚	@author	0m 0s		The patch does not contain any @author tags.
+1 💚	test4tests	0m 0s		The patch appears to include 1 new or modified test files.
			_ trunk Compile Tests _
+1 💚	mvninstall	25m 37s		trunk passed
+1 💚	compile	0m 56s		trunk passed with JDK Ubuntu-21.0.11+10-1-24.04.2-Ubuntu
+1 💚	compile	0m 56s		trunk passed with JDK Ubuntu-17.0.19+10-1-24.04.2-Ubuntu
+1 💚	checkstyle	1m 2s		trunk passed
+1 💚	mvnsite	1m 8s		trunk passed
+1 💚	javadoc	0m 52s		trunk passed with JDK Ubuntu-21.0.11+10-1-24.04.2-Ubuntu
+1 💚	javadoc	0m 52s		trunk passed with JDK Ubuntu-17.0.19+10-1-24.04.2-Ubuntu
+1 💚	spotbugs	2m 14s		trunk passed
+1 💚	shadedclient	17m 29s		branch has no errors when building and testing our client artifacts.
			_ Patch Compile Tests _
+1 💚	mvninstall	0m 46s		the patch passed
+1 💚	compile	0m 43s		the patch passed with JDK Ubuntu-21.0.11+10-1-24.04.2-Ubuntu
+1 💚	javac	0m 43s		the patch passed
+1 💚	compile	0m 44s		the patch passed with JDK Ubuntu-17.0.19+10-1-24.04.2-Ubuntu
+1 💚	javac	0m 44s		the patch passed
+1 💚	blanks	0m 0s		The patch has no blanks issues.
+1 💚	checkstyle	0m 43s		the patch passed
+1 💚	mvnsite	0m 46s		the patch passed
+1 💚	javadoc	0m 37s		the patch passed with JDK Ubuntu-21.0.11+10-1-24.04.2-Ubuntu
+1 💚	javadoc	0m 36s		the patch passed with JDK Ubuntu-17.0.19+10-1-24.04.2-Ubuntu
+1 💚	spotbugs	2m 6s		the patch passed
+1 💚	shadedclient	17m 1s		patch has no errors when building and testing our client artifacts.
			_ Other Tests _
-1 ❌	unit	181m 6s	/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt	hadoop-hdfs in the patch passed.
+1 💚	asflicense	0m 27s		The patch does not generate ASF License warnings.
		256m 24s

Reason	Tests
Failed junit tests	hadoop.hdfs.TestBlockRecoveryCauseStandbyNameNodeCrash

Subsystem	Report/Notes
Docker	ClientAPI=1.55 ServerAPI=1.55 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-8334/6/artifact/out/Dockerfile
GITHUB PR	#8334
Optional Tests	dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets
uname	Linux cf218c60348e 5.15.0-181-generic #191-Ubuntu SMP Fri May 22 19:09:02 UTC 2026 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/bin/hadoop.sh
git revision	trunk / `07d80aa`
Default Java	Ubuntu-17.0.19+10-1-24.04.2-Ubuntu
Multi-JDK versions	/usr/lib/jvm/java-21-openjdk-amd64:Ubuntu-21.0.11+10-1-24.04.2-Ubuntu /usr/lib/jvm/java-17-openjdk-amd64:Ubuntu-17.0.19+10-1-24.04.2-Ubuntu
Test Results	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-8334/6/testReport/
Max. process+thread count	4392 (vs. ulimit of 10000)
modules	C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs
Console output	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-8334/6/console
versions	git=2.43.0 maven=3.9.15 spotbugs=4.9.7
Powered by	Apache Yetus 0.14.1 https://yetus.apache.org

This message was automatically generated.

github-actions Bot added HDFS trunk labels Mar 9, 2026

deepujain force-pushed the HDFS-17850-append-reject-same-generation-stamp branch from b40483d to 261c748 Compare June 15, 2026 07:07

deepujain force-pushed the HDFS-17850-append-reject-same-generation-stamp branch from 261c748 to 2f536d1 Compare July 9, 2026 07:53

deepujain force-pushed the HDFS-17850-append-reject-same-generation-stamp branch from 2f536d1 to 39d8560 Compare July 11, 2026 03:58

HDFS-17850. Reject append when new generation stamp equals or is less…

8886e2d

… than replica.

deepujain force-pushed the HDFS-17850-append-reject-same-generation-stamp branch from 39d8560 to 8886e2d Compare August 4, 2026 13:25

Trigger CI

07d80aa

Uh oh!

Conversation

deepujain commented Mar 9, 2026

Summary

Change

JIRA

Uh oh!

hadoop-yetus commented Mar 10, 2026

Uh oh!

deepujain commented May 27, 2026

Uh oh!

deepujain commented Jun 14, 2026

Uh oh!

hfutatzhanghb commented Jun 15, 2026

Uh oh!

deepujain commented Jun 15, 2026

Uh oh!

hadoop-yetus commented Jun 15, 2026

Uh oh!

deepujain commented Jun 26, 2026

Uh oh!

deepujain commented Jul 6, 2026

Uh oh!

deepujain commented Jul 9, 2026

Uh oh!

hadoop-yetus commented Jul 9, 2026

Uh oh!

deepujain commented Jul 9, 2026

Uh oh!

deepujain commented Jul 10, 2026

Uh oh!

deepujain commented Jul 10, 2026

Uh oh!

deepujain commented Jul 11, 2026

Uh oh!

hadoop-yetus commented Jul 11, 2026

Uh oh!

deepujain commented Jul 13, 2026

Uh oh!

deepujain commented Jul 20, 2026

Uh oh!

deepujain commented Jul 21, 2026

Uh oh!

deepujain commented Jul 21, 2026

Uh oh!

deepujain commented Jul 26, 2026

Uh oh!

deepujain commented Aug 4, 2026

Uh oh!

deepujain commented Aug 5, 2026

Uh oh!

hadoop-yetus commented Aug 5, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants