HADOOP-19951. Remove use of jetty-util-ajax and use jackson instead - #8654
Draft
pjfanning wants to merge 15 commits into
Draft
HADOOP-19951. Remove use of jetty-util-ajax and use jackson instead#8654pjfanning wants to merge 15 commits into
pjfanning wants to merge 15 commits into
Conversation
ajfabbri
reviewed
Aug 3, 2026
ajfabbri
left a comment
ajfabbri
left a comment
Contributor
There was a problem hiding this comment.
LGTM except I had a couple of questions.
| so keeping it here leads to conflicts. | ||
| --> | ||
| <exclude>org.eclipse.jetty:jetty-util</exclude> | ||
| <exclude>org.eclipse.jetty:jetty-util-ajax</exclude> |
Contributor
There was a problem hiding this comment.
Curious why we need shading exclusion if this is no longer a dependency?
| <exclude>ch.qos.reload4j:reload4j</exclude> | ||
| <exclude>org.eclipse.jetty.websocket:websocket-common</exclude> | ||
| <exclude>org.eclipse.jetty.websocket:websocket-api</exclude> | ||
| <exclude>org.eclipse.jetty:jetty-util-ajax</exclude> |
Member
Author
There was a problem hiding this comment.
it seems like it is a transitive dependency - I'll investigate and see if I can exclude it as a transitive dependency
pjfanning
marked this pull request as draft
August 3, 2026 19:33
pan3793
reviewed
Aug 4, 2026
| */ | ||
| @InterfaceAudience.Private | ||
| @InterfaceStability.Unstable | ||
| public final class HadoopJsonUtils { |
Member
There was a problem hiding this comment.
can we just call it JsonUtil or JsonUtils ? - there are no existing classes under this folder that start with Hadoop*
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
rework HadoopJsonUtils HadoopJsonUtils.toStrin
rename as JsonUtils typo
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of PR
HADOOP-19951
Contains content generated by Claude / Xiaomi Mimo.
How was this patch tested?
CI build
For code changes:
LICENSE,LICENSE-binary,NOTICE-binaryfiles?AI Tooling
If an AI tool was used:
where is the name of the AI tool used.
https://www.apache.org/legal/generative-tooling.html