Skip to content

YARN-11974. CS UI: comma-separated usernames in placement rule form - #8657

Open
myloginid wants to merge 2 commits into
apache:trunkfrom
myloginid:YARN-11974-cs-ui
Open

YARN-11974. CS UI: comma-separated usernames in placement rule form#8657
myloginid wants to merge 2 commits into
apache:trunkfrom
myloginid:YARN-11974-cs-ui

Conversation

@myloginid

@myloginid myloginid commented Aug 4, 2026

Copy link
Copy Markdown

Summary

Update the Apache Capacity Scheduler UI (hadoop-yarn-capacity-scheduler-ui) placement rule form to support comma-separated usernames in the Match Pattern field.

This is not Cloudera Manager or Queue Manager code — it is the upstream YARN Capacity Scheduler web UI shipped in hadoop-yarn-project.

Changes

  • PlacementRuleForm.tsx — placeholder and help text for comma-separated usernames
  • placement-rule-schema.ts — reject empty tokens between commas (e.g. alice,,bob)

Dependencies

  • Requires YARN-11973 (RM engine) for comma-separated values to take effect at runtime

Related

Test plan

  • Manual: enter alice,bob in user rule Match Pattern; verify save/load round-trip
  • Manual: verify alice,,bob shows validation error

Sub-task of YARN-11972.
Fixes: https://issues.apache.org/jira/browse/YARN-11974

Update PlacementRuleForm help text and placement-rule-schema validation
for comma-separated user match patterns.

Sub-task of YARN-11972. Depends on YARN-11973.

Co-authored-by: Cursor <cursoragent@cursor.com>
@myloginid

Copy link
Copy Markdown
Author

Please add labels: trunk, YARN

@hadoop-yetus

Copy link
Copy Markdown

💔 -1 overall

Vote Subsystem Runtime Logfile Comment
+0 🆗 reexec 7m 42s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+0 🆗 codespell 0m 0s codespell was not available.
+0 🆗 detsecrets 0m 0s detect-secrets was not available.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
_ trunk Compile Tests _
+1 💚 mvninstall 28m 40s trunk passed
+1 💚 shadedclient 44m 19s branch has no errors when building and testing our client artifacts.
_ Patch Compile Tests _
-1 ❌ mvninstall 0m 36s /patch-mvninstall-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-capacity-scheduler-ui.txt hadoop-yarn-capacity-scheduler-ui in the patch failed.
+1 💚 blanks 0m 0s The patch has no blanks issues.
+1 💚 shadedclient 14m 56s patch has no errors when building and testing our client artifacts.
_ Other Tests _
+1 💚 asflicense 0m 31s The patch does not generate ASF License warnings.
69m 24s
Subsystem Report/Notes
Docker ClientAPI=1.55 ServerAPI=1.55 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-8657/1/artifact/out/Dockerfile
GITHUB PR #8657
Optional Tests dupname asflicense shadedclient codespell detsecrets
uname Linux a4501107fe5f 5.15.0-181-generic #191-Ubuntu SMP Fri May 22 19:09:02 UTC 2026 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/bin/hadoop.sh
git revision trunk / 094cf7c
Max. process+thread count 634 (vs. ulimit of 10000)
modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-capacity-scheduler-ui U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-capacity-scheduler-ui
Console output https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-8657/1/console
versions git=2.43.0 maven=3.9.15
Powered by Apache Yetus 0.14.1 https://yetus.apache.org

This message was automatically generated.

Restore the missing message block on the group wildcard refine so the
comma-separated username validation compiles.

Co-authored-by: Cursor <cursoragent@cursor.com>
@hadoop-yetus

Copy link
Copy Markdown

🎊 +1 overall

Vote Subsystem Runtime Logfile Comment
+0 🆗 reexec 0m 20s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+0 🆗 codespell 0m 0s codespell was not available.
+0 🆗 detsecrets 0m 0s detect-secrets was not available.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
_ trunk Compile Tests _
+1 💚 mvninstall 27m 25s trunk passed
+1 💚 shadedclient 43m 27s branch has no errors when building and testing our client artifacts.
_ Patch Compile Tests _
+1 💚 mvninstall 0m 47s the patch passed
+1 💚 blanks 0m 0s The patch has no blanks issues.
+1 💚 shadedclient 15m 7s patch has no errors when building and testing our client artifacts.
_ Other Tests _
+1 💚 asflicense 0m 30s The patch does not generate ASF License warnings.
61m 21s
Subsystem Report/Notes
Docker ClientAPI=1.55 ServerAPI=1.55 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-8657/2/artifact/out/Dockerfile
GITHUB PR #8657
Optional Tests dupname asflicense shadedclient codespell detsecrets
uname Linux cf2313e6e480 5.15.0-181-generic #191-Ubuntu SMP Fri May 22 19:09:02 UTC 2026 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/bin/hadoop.sh
git revision trunk / 807e796
Max. process+thread count 640 (vs. ulimit of 10000)
modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-capacity-scheduler-ui U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-capacity-scheduler-ui
Console output https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-8657/2/console
versions git=2.43.0 maven=3.9.15
Powered by Apache Yetus 0.14.1 https://yetus.apache.org

This message was automatically generated.

@Hean-Chhinling Hean-Chhinling left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @myloginid for working on this.
LGTM!

@slfan1989 slfan1989 self-assigned this Aug 5, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants