issue #7245 : show unit test variables in pipeline run dialog#7490
Merged
Conversation
Move HopGuiPipelineExecutionConfiguration so plugins can enrich the execution configuration before the run dialog opens. Add an extension point that injects the active unit test variables (and parameter-named entries) so they appear for review and edit on Launch.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
When a pipeline unit test is selected in Hop GUI, its configured variables are now pre-loaded into the Variables (and Parameters) tabs of the pipeline execution dialog so the user can review and change them before running.
Details
HopGuiPipelineExecutionConfigurationinHopGuiPipelineRunDelegate.executePipeline()to before the run configuration dialog (matching the extension point description).HopGuiUnitTestVariablesExtensionPointin the testing plugin to copy active unit-test variables into the execution configuration.What was tested?
HopGuiUnitTestVariablesExtensionPointTest(6 tests)How can this be tested?
Fixes: #7245