feat(expr): evaluate prefix predicates with strict metrics - #2889
Open
fallintoplace wants to merge 2 commits into
Open
feat(expr): evaluate prefix predicates with strict metrics#2889fallintoplace wants to merge 2 commits into
fallintoplace wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
N/A. Found while comparing
StrictMetricsEvaluatorwith the Java reference implementation and the sibling metrics evaluators.What changes are included in this PR?
Strict metrics evaluation answers whether every row in a data file must match a predicate. It previously returned
falseforstartsWithandnotStartsWitheven when file bounds proved the result.This PR adds conservative proofs for both predicates:
startsWithreturnstrueonly when null metrics prove there are no nulls and both string bounds start with the requested prefixnotStartsWithreturnstruewhen the column is entirely null, or when a truncated lower or upper bound proves the requested prefix is outside the possible value rangefalseThe bound comparisons use iterators and do not allocate temporary truncated strings.
Are these changes tested?
Yes. Unit tests cover matching and non-matching bounds, missing bounds, null-containing files, all-null files, prefix overlap, and invalid non-string bounds.
Validated with:
cargo test -p iceberg expr::visitors::strict_metrics_evaluator::test --libcargo clippy -p iceberg --lib -- -D warnings