fix(spec): format pre-epoch timestamptz values - #2892
Open
fallintoplace wants to merge 1 commit into
Open
Conversation
fallintoplace
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
N/A. Found while auditing temporal conversions for values before the Unix epoch.
What changes are included in this PR?
Formatting a timestamptz immediately before the Unix epoch could panic. The conversion split the value with integer division and remainder, then cast the negative remainder to an unsigned nanosecond value before constructing the timestamp.
This PR uses Chrono timestamp constructors for both microsecond and nanosecond timestamptz values. These constructors normalize negative timestamps correctly and match the conversion already used for timestamps without a timezone.
Are these changes tested?
Yes. A regression test covers display formatting and JSON round trips for values one microsecond and one nanosecond before the Unix epoch.
Validated with:
cargo test -p iceberg --libcargo clippy -p iceberg --lib -- -D warnings