fix(transform): preserve decimal types in truncate projections - #2893
Open
fallintoplace wants to merge 1 commit into
Open
fix(transform): preserve decimal types in truncate projections#2893fallintoplace wants to merge 1 commit into
fallintoplace wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
N/A. Found while auditing truncate transforms and predicate projection.
What changes are included in this PR?
Decimal truncate operations rebuilt transformed values as scale-0 decimals with maximum precision. That changed the literal type and made projected predicates display raw mantissas, such as
10000instead of100.00.This PR preserves the source precision and scale when:
Projected literals now retain the decimal type of the source expression.
Are these changes tested?
Yes. Regression coverage verifies that decimal truncation and boundary adjustment preserve the original type. Existing strict and inclusive projection tests also verify scaled predicate values.
Validated with:
cargo test -p iceberg --libcargo clippy -p iceberg --lib -- -D warnings