feat(catalog-rest): add rustls TLS features - #2910
Open
rutgerclaes wants to merge 2 commits into
Open
Conversation
reqwest is built with default-features = false, so https:// catalog URIs only work when another crate in the dependency tree happens to enable a TLS feature on reqwest 0.12. Then feature unification kicks in and makes it work. Add rustls-tls and rustls-tls-native-roots passthrough features, with rustls-tls-native-roots on by default so https works out of the box while default-features = false still yields a TLS-free build. Signed-off-by: Rutger Claes <rgc@rgc.be>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
What changes are included in this PR?
TLS passthrough features for iceberg-catalog-rest so https:// catalog URIs work out of the box:
rustls-tls-native-roots(default): rustls validating against the OS trust storerustls-tls: rustls validating against the compiled-in webpki root bundledefault-features = falsebuilds without a TLS stackNo code changes. Custom TLS settings (client certificates, extra roots) remain available by passing a preconfigured client to
RestCatalogBuilder::with_client.Are these changes tested?
Feature wiring only, no runtime code. Verified with cargo check for the default feature set, --no-default-features, and rustls-tls.
Adds the iceberg-catalog-rest to the existing "no-default-features" CI check.