chore(ci): Add check to Python release to verify workflow is running on expected tag - #2912
Open
dannycjones wants to merge 1 commit into
Open
chore(ci): Add check to Python release to verify workflow is running on expected tag#2912dannycjones wants to merge 1 commit into
dannycjones wants to merge 1 commit into
Conversation
blackmwk
reviewed
Jul 28, 2026
|
|
||
|
|
||
| # Verify that the workflow is being run on the same version as the release tag | ||
| DESIRED_REF="refs/tags/${RELEASE_TAG}" |
Contributor
There was a problem hiding this comment.
Is it possible to forbid non tag refs in the workflow dispatch arg?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Addresses issue where pyiceberg-core was released from
mainrather than the release branch.The change should prevent this scenario from recurring.
What changes are included in this PR?
The code will checkout the ref it was executed with, and this change asserts that we're on a tagged commit.
It may be worth removing the input version argument and simply using the tag that the workflow was invoked with - this is enough information. However, I wanted to keep changes simple for now.
Are these changes tested?
Yes, manually: