fix: table UUID partitions not working - #2916
Conversation
|
A few notes ... Avro has an The other thing I found is with the integration tests. I found when I had multiple tests in the same file it would fail with a Reqwest + Tokio error. I believe in As a workaround I put my second test into a second file. I'd be happy to try to solve this in a followup ticket if there is interest, and any other work to make test simpler. The solution is technically straight forward, but would be a chunk of code. We are talking a custom S3 storage layer, changing OpenDal core, or moving to use |
f92395e to
de83553
Compare
blackmwk
left a comment
There was a problem hiding this comment.
Thanks @JosephLenton for this fix!
There was a problem hiding this comment.
We should not add more integration tests in this mod, it only exists for compatibility.
There was a problem hiding this comment.
If you want to add such kind of test, you should add some slt test in datafusion integration.
| }, | ||
| RawLiteralEnum::String(v) => match ty { | ||
| Type::Primitive(PrimitiveType::String) => Ok(Some(Literal::string(v))), | ||
| Type::Primitive(PrimitiveType::Uuid) => { |
There was a problem hiding this comment.
I want to see ut for this change
Which issue does this PR close?
Table Partitions work on writing with UUID values.
What changes are included in this PR?
PrimitiveLiteral::UInt128will now convert to aRawLiteralEnum::String, when the type is UUID.RawLiteralEnumfor UUID deserialisation.Are these changes tested?
I added: