ci: aggregate gate job + branch-0.4 required checks for spark-runtime - #862
Open
rangareddy wants to merge 2 commits into
Open
ci: aggregate gate job + branch-0.4 required checks for spark-runtime#862rangareddy wants to merge 2 commits into
rangareddy wants to merge 2 commits into
Conversation
Add a spark-runtime-validation-required job that depends on the validate-spark-runtime-bundle matrix and passes only when every leg succeeds. This exposes a single stable status context so branch protection can require one check name instead of listing each Spark version (validate-spark-runtime-bundle (3.4.3) / (3.5.9)), which cannot use wildcards. Uses if: always() so the gate still reports (not skipped) when a matrix leg fails.
Add a branch-0.4 protected_branches block requiring Maven CI Build, License Check and the new spark-runtime-validation-required gate context. Note: ASF applies .asf.yaml github settings only from the default branch (main), so this block documents branch-0.4's intended protection and takes effect through main's .asf.yaml rather than this file.
rangareddy
changed the title
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Adds a single aggregate "gate" job to
spark-runtime-validation.ymlso branch protection can require one stable status context for the Spark-runtime bundle validation instead of listing every matrix version, plus abranch-0.4protection block in.asf.yaml.Follow-up to the review discussion on #848:
.asf.yaml/ GitHub branch protection match required status checks by exact name (no wildcards), so a matrix job forces you to enumeratevalidate-spark-runtime-bundle (3.4.3)and(3.5.9)— and re-edit.asf.yamlevery time the Spark matrix changes.Changes
spark-runtime-validation.yml— new jobspark-runtime-validation-requiredthatneeds: validate-spark-runtime-bundleand fails unless the aggregated matrix result issuccess(needs.<job>.resultissuccessonly when all legs pass).if: always()is used deliberately: without it the gate is skipped when a leg fails, and a skipped required check leaves a PR stuck on a pending status. The matrix job is unchanged..asf.yaml— adds abranch-0.4protected_branchesblock requiringMaven CI Build,License Checkandspark-runtime-validation-required.Important caveat on the
.asf.yamlblockASF applies
.asf.yamlgithub:settings (branch protection included) only from the default branch (main). Thisbranch-0.4block therefore documents the intended protection but does not take effect from this file — the effective registration must also live inmain's.asf.yaml(that's what #848 does). Kept here for parity/self-documentation; a maintainer should ensuremain's.asf.yamlrequiresspark-runtime-validation-requiredforbranch-0.4(see the suggestion left on #848).Merge order
Merge this gate job first so the
spark-runtime-validation-requiredcontext exists onbranch-0.4, then require it inmain's.asf.yaml(#848).Testing
YAML validated locally; job graph confirmed (gate depends on the matrix job,
if: always(), exits non-zero unless aggregated result issuccess);.asf.yamlparses and declares the three required contexts forbranch-0.4.