[865] Remove orphaned license files from bundled jars - #866
Open
rangareddy wants to merge 1 commit into
Open
Conversation
These META-INF/licenses/ files are for libraries that are not shaded into the respective bundled jar (their artifacts are not in the shade <artifactSet><includes>, so no classes are present): - xtable-aws: LICENSE-antlr4-runtime, LICENSE-glassfish-java-servlet-jsp, LICENSE-slf4j-api - xtable-hudi-support-extensions: LICENSE-antlr4-runtime, LICENSE-javax-annotation-api - xtable-hive-metastore: LICENSE-slf4j-api Remove them so the bundled license metadata matches the jar contents.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Removes orphaned
META-INF/licenses/LICENSE-*files from the bundled (shaded) jars — license texts for libraries that are not actually bundled (no classes present), because their artifacts are not in the shade<artifactSet><includes>.Closes #865
Removed files (verified against each module's shade includes)
xtable-awsLICENSE-antlr4-runtime,LICENSE-glassfish-java-servlet-jsp,LICENSE-slf4j-apixtable-hudi-support-extensionsLICENSE-antlr4-runtime,LICENSE-javax-annotation-apixtable-hive-metastoreLICENSE-slf4j-apiorg.slf4j:slf4j-apiis not shaded hereKept where the library is bundled — e.g.
LICENSE-javax-annotation-apiinxtable-aws(javax.annotation:javax.annotation-apiis in its includes) andLICENSE-slf4j-apiinxtable-hudi-support-extensions(org.slf4j:slf4j-apiis in its includes).Verification
For each removed file I confirmed the corresponding artifact is absent from the module's
maven-shade-plugin<artifactSet><includes>, so its classes are not in the jar and the license text is orphaned.Note
The larger PR #857 (bundle license texts for non-Apache-2.0 dependencies) regenerates the entire
META-INF/licenses/directory and would also remove these orphans as a side effect; this PR is the minimal, targeted fix for #865 and can merge independently.