Skip to content

Pipe: Remove Ratis data region source restriction #18089

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Caideyipi wants to merge 1 commit into
base: master
Choose a base branch
from
+0 −14
Open

Pipe: Remove Ratis data region source restriction #18089

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions iotdb-core/datanode/src/main/i18n/en/org/apache/iotdb/db/i18n/DataNodePipeMessages.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -611,8 +611,6 @@ public final class DataNodePipeMessages {
"The pipe cannot extract table model data when sql dialect is set to tree.";
public static final String THE_PIPE_CANNOT_EXTRACT_TREE_MODEL_DATA =
"The pipe cannot extract tree model data when sql dialect is set to table.";
public static final String THE_PIPE_CANNOT_TRANSFER_DATA_WHEN_DATA =
"The pipe cannot transfer data when data region is using ratis consensus.";
public static final String THE_REFERENCE_COUNT_OF_THE_EVENT_CANNOT =
"The reference count of the event {} cannot be increased, skipping it.";
public static final String THE_REFERENCE_COUNT_OF_THE_REALTIME_EVENT =
Expand Down
2 changes: 0 additions & 2 deletions iotdb-core/datanode/src/main/i18n/zh/org/apache/iotdb/db/i18n/DataNodePipeMessages.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -584,8 +584,6 @@ public final class DataNodePipeMessages {
"The pipe cannot extract table model data when sql dialect is set to tree.";
public static final String THE_PIPE_CANNOT_EXTRACT_TREE_MODEL_DATA =
"The pipe cannot extract tree model data when sql dialect is set to table.";
public static final String THE_PIPE_CANNOT_TRANSFER_DATA_WHEN_DATA =
"The pipe cannot transfer data when data region is using ratis consensus.";
public static final String THE_REFERENCE_COUNT_OF_THE_EVENT_CANNOT =
"The reference count of the event {} cannot be increased, skipping it.";
public static final String THE_REFERENCE_COUNT_OF_THE_REALTIME_EVENT =
Expand Down
10 changes: 0 additions & 10 deletions ...anode/src/main/java/org/apache/iotdb/db/pipe/source/dataregion/IoTDBDataRegionSource.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,8 +27,6 @@
import org.apache.iotdb.commons.pipe.datastructure.pattern.TreePattern;
import org.apache.iotdb.commons.pipe.source.IoTDBSource;
import org.apache.iotdb.commons.queryengine.common.SqlDialect;
import org.apache.iotdb.consensus.ConsensusFactory;
import org.apache.iotdb.db.conf.IoTDBDescriptor;
import org.apache.iotdb.db.i18n.DataNodePipeMessages;
import org.apache.iotdb.db.pipe.event.common.heartbeat.PipeHeartbeatEvent;
import org.apache.iotdb.db.pipe.metric.overview.PipeDataNodeSinglePipeMetrics;
Expand Down Expand Up @@ -152,14 +150,6 @@ public void validate(final PipeParameterValidator validator) throws Exception {
hasNoExtractionNeed = false;
shouldExtractDeletion = insertionDeletionListeningOptionPair.getRight();

if (insertionDeletionListeningOptionPair.getLeft().equals(true)
&& IoTDBDescriptor.getInstance()
.getConfig()
.getDataRegionConsensusProtocolClass()
.equals(ConsensusFactory.RATIS_CONSENSUS)) {
throw new PipeException(DataNodePipeMessages.THE_PIPE_CANNOT_TRANSFER_DATA_WHEN_DATA);
}

// Validate source.pattern.format is within valid range
validator
.validateAttributeValueRange(
Expand Down
Loading