Skip to content

[To dev/1.3] Handle invalid DataNode id in region operations - #18477

Closed
CRZbulabula wants to merge 1 commit into
apache:dev/1.3from
CRZbulabula:yongzao/v1-411-invalid-datanode-region-operations
Closed

[To dev/1.3] Handle invalid DataNode id in region operations#18477
CRZbulabula wants to merge 1 commit into
apache:dev/1.3from
CRZbulabula:yongzao/v1-411-invalid-datanode-region-operations

Conversation

@CRZbulabula

Copy link
Copy Markdown
Contributor

Description

Semantic backport of #18075 to dev/1.3.

Behavior

  • Resolve the target DataNode before processing reconstruct and extend region requests.
  • Return RECONSTRUCT_REGION_ERROR or EXTEND_REGION_ERROR with the target id when it is not a registered DataNode, including when a ConfigNode id is supplied.
  • Avoid region resolution and procedure submission for invalid targets.
  • Preserve the existing behavior for registered DataNodes.

Tests

  • ProcedureManagerRegionOperationTest
  • IoTDBRegionGroupExpandAndShrinkForIoTV1IT#rejectInvalidTargetDataNodeTest
  • IoTDBRegionReconstructForIoTV1IT#rejectInvalidTargetDataNodeTest
  • IoTDBRegionGroupExpandAndShrinkForIoTV1IT#singleRegionTest
  • Checkstyle and Spotless

This PR has:

  • been self-reviewed.
  • added unit tests.
  • added integration tests.
  • been tested in a test IoTDB cluster.

Key changed/added classes
  • ProcedureManager
  • ProcedureManagerRegionOperationTest
  • IoTDBRegionGroupExpandAndShrinkForIoTV1IT
  • IoTDBRegionReconstructForIoTV1IT

@CRZbulabula

Copy link
Copy Markdown
Contributor Author

Superseded by #18478, whose head branch is hosted directly in apache/iotdb.

@CRZbulabula
CRZbulabula deleted the yongzao/v1-411-invalid-datanode-region-operations branch August 16, 2026 04:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant