[LIVY-749] Remove explicitly adding datanucleus jars#280
Conversation
merge from upstream
[MINOR] Remove unused guava import
Signed-off-by: Shanyu Zhao <shzhao@microsoft.com>
Codecov Report
@@ Coverage Diff @@
## master #280 +/- ##
===========================================
- Coverage 68.54% 68.4% -0.14%
- Complexity 906 964 +58
===========================================
Files 100 104 +4
Lines 5674 5934 +260
Branches 854 895 +41
===========================================
+ Hits 3889 4059 +170
- Misses 1228 1295 +67
- Partials 557 580 +23
Continue to review full report at Codecov.
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #280 +/- ##
============================================
+ Coverage 68.20% 68.40% +0.19%
+ Complexity 965 964 -1
============================================
Files 104 104
Lines 5951 5934 -17
Branches 900 895 -5
============================================
Hits 4059 4059
+ Misses 1314 1295 -19
- Partials 578 580 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
This pull request has been automatically marked as stale because it has had no activity for at least 3 months. If you are still working on this change or plan to move it forward, please leave a comment or push a new commit so we know to keep it open. Otherwise, this PR will be closed automatically in about one month. Thank you for your contribution to Apache Livy! |
What changes were proposed in this pull request?
https://issues.apache.org/jira/browse/LIVY-749
If we start any Livy session with hive support (livy.repl.enable-hive-context=true), we see that 3 datanucleus jars are uploaded to HDFS and downloaded to drivers/executors:
Uploading resource file:/opt/spark/jars/datanucleus-api-jdo-3.2.6.jar -> hdfs://namenode/user/test1/.sparkStaging/application_1581024490249_0002/datanucleus-api-jdo-3.2.6.jar
...
These 3 datanucleus jars are not needed bacause they are already included in Spark 2.x jars folder.
The reason is because in InteractiveSession.scala, method mergeHiveSiteAndHiveDeps(), we merged datanucleus jars to spark.jars list with method datanucleusJars(). We should remove datanucleusJars() function.
How was this patch tested?
existing unit/integration tests, and manual tests.
Please review https://livy.incubator.apache.org/community/ before opening a pull request.