[MDEP-726]: dependency:copy finds missing versions in TRANSITIVE depend…#109
Draft
mkarg wants to merge 2 commits into
Draft
[MDEP-726]: dependency:copy finds missing versions in TRANSITIVE depend…#109mkarg wants to merge 2 commits into
mkarg wants to merge 2 commits into
Conversation
…encies Signed-off-by: Markus KARG <markus@headcrashing.eu>
mkarg
changed the title
|
Resolve #1240 |
slawekjaranowski
added
the
waiting-for-feedback
|
This pull request is stale because it has been waiting for feedback for 60 days. Remove the stale label or comment on this PR, or it will be automatically closed in 30 days. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Status
This PR is a work-in-progress, as the solution is still under construction.
Description
This PR solves MDEP-726 by replacing the original version lookup (which was limited to direct dependencies and managed dependencies) by a code variant which performs a real transitive resolution. As a result, missing version numbers are working fine when copying transitive dependencies.
Help Wanted
While this PR works well with real projects, it fails in the existing unit test with
NullPointerException, due to missing GAV coordinates in the test mockup. If someone has an idea how to fix it, please tell me! :-)