fix: Some since javadoc tags were off; fixed#1968
Conversation
kwin
left a comment
There was a problem hiding this comment.
I would very much favor to make the next version a minor upgrade (to indicate new features), i.e. 2.1.0
gnodet
left a comment
There was a problem hiding this comment.
Initial review — javadoc @since tag corrections
Changes reviewed:
- 8 occurrences of
@since NEXT→@since 2.0.21across 6 files (transport property APIs from recent PRs #1762, #1949, #1965) - 1 historical correction:
ManagedScopeDeriver@since 4.0.0→@since 2.0.0-alpha-9(matches the MRESOLVER-512 introduction in the 2.0.0-alpha-9 release)
Observations:
- Clean sweep — verified no remaining
@since NEXTplaceholders in the codebase after this PR ManagedScopeDerivercorrection is accurate — the class was introduced in commit 39452f7 (MRESOLVER-512), which shipped in 2.0.0-alpha-9- CI failure on ubuntu/jdk-25 appears unrelated (javadoc-only change, master passes)
The version number discussion (2.0.21 vs 2.1.0) is already being discussed between maintainers — no additional input from us on that topic.
Verdict: ✅ The javadoc changes are well-scoped and the @since tag corrections are accurate. Ready to merge once the version number is settled.
Reviewed with AI on behalf of @gnodet. This review was generated by an AI agent and may contain inaccuracies; please verify all suggestions before applying.
Resolver (nor Maven project) was not semver, and IMO if we start right now (out of the blue) to follow semver, that could be misleading to many users. Not to mention, how we already "scare" our users with Resolver 1 vs Resolver 2 APIs, and now we'd throw on them Resolver 2.1... while I agree with assessment, I would not do 2.1.0 now. The major version milestones were once recorded on this page https://cwiki.apache.org/confluence/spaces/MAVEN/pages/181305684/Maven+Ecosystem+Cleanup#MavenEcosystemCleanup-ResolverandMaven but of course are not in stone, but changing versioning to semver would require broader discussion. Right now, we want GA versions of Maven 3 and 4 using same Resolver 2, with all the promises with backward compatibility we gave. |
Fix javadoc since tags.