GH-600: Allow TimestampType to annotate FLBA(12) - #601
Open
divjotarora wants to merge 1 commit into
Open
Conversation
stevomitric
approved these changes
Jul 21, 2026
alkis
reviewed
Jul 27, 2026
| since the Unix epoch. | ||
|
|
||
| For the `FIXED_LEN_BYTE_ARRAY` carrier (with `type_length = 12`), the value is a | ||
| signed 96-bit two's-complement little-endian integer count of `unit`s since the |
Contributor
There was a problem hiding this comment.
I suggest we do big-endian here so that we can use the same signed two complements byte compare we use for DECIMAL in FLBA.
Contributor
Author
There was a problem hiding this comment.
I chose little-endian because it seems to match the rest of the spec (DECIMAL is the only deviation). But I don't have a strong preference, happy to change it to big-endian. I'd like to hear from others to see if anyone else agrees/disagrees.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale for this change
This PR implements the changes described in the proposal document to add support for extended precision nanosecond timestamps that cover the full ANSI SQL timestamp range (years 0000-9999).
What changes are included in this PR
Spec changes to allow the
TimestampTypelogical type to annotate theFIXED_LEN_BYTE_ARRAYphysical type withtype_length = 12.Do these changes have PoC implementations?
The parquet-java change is in progress.
Closes #600