RATIS-2581. Route file operations through NIO.2#1499
Merged
Conversation
HTHou
changed the title
HTHou
force-pushed
the
ratis-2581-file-destroyer
branch
4 times, most recently
from
cb7edeb to
7bd1336
Compare
HTHou
force-pushed
the
ratis-2581-file-destroyer
branch
from
7bd1336 to
435f83f
Compare
HTHou
changed the title
szetszwo
approved these changes
Jul 3, 2026
szetszwo
left a comment
szetszwo
left a comment
Contributor
There was a problem hiding this comment.
+1 the change looks good.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Route a few remaining Ratis file operations through Java NIO.2 so they can be intercepted by the default
FileSystemProvider.This patch removes direct use of
File.delete()fromAtomicFileOutputStream#abort, opens segmented log write channels throughFileChannel.open(Path, ...)instead ofRandomAccessFile#getChannel, and routes zero-size open log segment deletion throughFileUtils.With these changes, downstream projects that install a custom default
FileSystemProvidercan cover these cleanup and truncate paths without adding a Ratis-specific file destruction API.https://issues.apache.org/jira/browse/RATIS-2581
How was this patch tested?
git diff --checkandgit diff --cached --check../mvnw -pl ratis-common -Dtest=TestFileUtils test../mvnw -pl ratis-server -am -DskipTests compile.