[MINOR] Clean up of isDebugEnabled() usages

[e-strauss]

This PR is a followup to #2432 .
We have 131 Usages of LOG.isDebugEnabled()

grep -rnF "LOG.isDebugEnabled" src/main/java/org/apache/sysds | wc -l
131

This PR adds a new utils for Parameterized Logging

LOG.debug("Begin Function {%15d}", fkey);
// instead of
if(LOG.isDebugEnabled){
    LOG.debug(String.format("Begin Function %15d", fkey))
}

This helps with readability and simplifies code coverage

[Baunsgaard]

The main difference here, is that the LOG.isDebugEnabled() is very cheap, while the string concatenation can be very expensive. Unfortunately to call the LOG.debug java has to resolve the string variable input, and that is the main time used, especially if Logging is disabled.

I do not know if there is a way to avoid the string concatenation, or somehow getting it delayed to after the logging is analysed to be off.

[e-strauss]

I see your point, but isnt it in practice in micro-level noise for these simple concats? i think we might over-engineer here

Why are we sticking to apache commons logging? with the newer SLF4J we would could do stuff like this:

LOG.debug("Begin Function {}", fkey);

also SLF4J might already be used inside apachae commons logging, since it's already in the pom

[Baunsgaard]

This would be cool, but we should not change the logging framework, so we just need to verify.

[codecov]

Codecov Report

❌ Patch coverage is 90.07353% with 27 lines in your changes missing coverage. Please review.
✅ Project coverage is 71.65%. Comparing base (e557836) to head (fba5fc4).

Files with missing lines	Patch %	Lines
...a/org/apache/sysds/hops/codegen/SpoofCompiler.java	9.09%	8 Missing and 2 partials ⚠️
.../runtime/controlprogram/caching/CacheableData.java	76.47%	2 Missing and 2 partials ⚠️
...apache/sysds/hops/rewrite/RewriteInjectOOCTee.java	57.14%	2 Missing and 1 partial ⚠️
...che/sysds/runtime/lineage/LineageRewriteReuse.java	81.25%	3 Missing ⚠️
...va/org/apache/sysds/utils/ParameterizedLogger.java	95.71%	1 Missing and 2 partials ⚠️
.../MultiReturnParameterizedBuiltinCPInstruction.java	50.00%	1 Missing and 1 partial ⚠️
...instructions/cp/ParamservBuiltinCPInstruction.java	90.90%	0 Missing and 1 partial ⚠️
...s/runtime/instructions/fed/InitFEDInstruction.java	83.33%	1 Missing ⚠️

Additional details and impacted files

@@             Coverage Diff              @@
##               main    #2435      +/-   ##
============================================
+ Coverage     71.61%   71.65%   +0.04%     
- Complexity    49867    49892      +25     
============================================
  Files          1602     1603       +1     
  Lines        193054   193062       +8     
  Branches      37792    37743      -49     
============================================
+ Hits         138247   138348     +101     
+ Misses        44031    43999      -32     
+ Partials      10776    10715      -61     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.