Skip to content

feat(gateway): raise prometheus-metrics and tracing_buffer shared-dict defaults#310

Merged
nic-6443 merged 3 commits into
mainfrom
feat/bump-shared-dict-defaults
Jul 10, 2026
Merged

feat(gateway): raise prometheus-metrics and tracing_buffer shared-dict defaults#310
nic-6443 merged 3 commits into
mainfrom
feat/bump-shared-dict-defaults

Conversation

@jarvis9443

Copy link
Copy Markdown
Contributor

Companion to api7/api7-ee-3-gateway#1947. The chart templates (and therefore overrides the image defaults for) two shared dicts, so they must be raised here for Helm-deployed gateways to get the larger, non-evictable dicts:

Value Old New
apisix.meta.luaSharedDict.prometheus-metrics 15m 256m
apisix.http.luaSharedDict.tracing_buffer 10m 32m

Discovery (kubernetes / nacos / consul) and api-calls-for-portal are not templated by the chart, so they inherit the new image defaults directly — no chart change needed for those.

These dicts reject writes and drop data when full with no self-healing eviction, so the previous defaults overflow on medium/large deployments (missing metrics, lost trace spans). Users who set explicit sizes are unaffected.

README regenerated via helm-docs; gateway chart version bumped 3.10.4 → 3.10.5.

Fixes api7/api7-ee-3-gateway#1869

…t defaults

Align the chart's overridden shared-dict sizes with the new gateway
defaults so Helm-deployed gateways get the larger, non-evictable dicts
without manual values overrides:

- meta.luaSharedDict.prometheus-metrics: 15m -> 256m
- http.luaSharedDict.tracing_buffer: 10m -> 32m

Discovery (kubernetes/nacos/consul) and api-calls-for-portal are not
templated by the chart, so they inherit the new image defaults directly.
Regenerated README via helm-docs; bumped chart version 3.10.4 -> 3.10.5.

Fixes api7/api7-ee-3-gateway#1869
@coderabbitai

coderabbitai Bot commented Jul 10, 2026

Copy link
Copy Markdown

Warning

Review limit reached

You’ve reached a temporary PR review limit under our Fair Usage Limits Policy.

Your recent review volume is higher than typical usage, so adaptive limits are currently applied.

Next review available in: 19 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 46ea75ff-07e1-4cf5-ab87-5509bf3d0b09

📥 Commits

Reviewing files that changed from the base of the PR and between 388079e and 22a4877.

📒 Files selected for processing (3)
  • charts/gateway/Chart.yaml
  • charts/gateway/README.md
  • charts/gateway/values.yaml
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch feat/bump-shared-dict-defaults

Comment @coderabbitai help to get the list of available commands.

…art values

Add the service-discovery (kubernetes / nacos / consul) and
api-calls-for-portal shared dicts as first-class chart values so operators
can size them without knowing the raw config passthrough:

- customLuaSharedDicts now defaults to kubernetes / nacos / consul at 64m
- http.luaSharedDict gains api-calls-for-portal at 64m

These match the gateway image defaults; custom_lua_shared_dict is deep-merged
over the image config, so unlisted dicts (e.g. config) are preserved.
Keep stream-mode Nacos discovery sized in line with the http nacos dict
so it does not reject newly discovered nodes at scale.
@nic-6443 nic-6443 merged commit 7fdc655 into main Jul 10, 2026
3 checks passed
@nic-6443 nic-6443 deleted the feat/bump-shared-dict-defaults branch July 10, 2026 07:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants