APIGOV-33064 Query Engage for latest version of agent for creating output of install command#291
Open
kasuvy wants to merge 2 commits into
Open
APIGOV-33064 Query Engage for latest version of agent for creating output of install command#291kasuvy wants to merge 2 commits into
kasuvy wants to merge 2 commits into
Conversation
…tput of install command
kasuvy
requested review from
alrosca,
dgghinea,
jcollins-axway,
jquick-axway,
sbolosan and
vivekschauhan
| @@ -837,7 +879,7 @@ export const GatewayTypeToDataPlane = { | |||
| }; | |||
|
|
|||
| export const PublicRepoUrl = 'https://axway.jfrog.io'; | |||
Contributor
Author
There was a problem hiding this comment.
I wanted to confirm about this. When I tried replacing it with "repository.axway.com" for download of agent config zip file, it did not work. So, I wasn't sure if it was the right place to look at and hence I put it back. The URL it looks for is "/artifactory/ampc-public-generic-release/aws-agents/aws_apigw_agent_config/latest/aws_apigw_agent_config-latest.zip"
Member
There was a problem hiding this comment.
If it needs retained, it should be changed to https://artifactory.axway.com since it's the same service. We should be preferring first party URLs over vendor's.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prior to Engage having its Component resource there was no place for the CLI to query for versions for a specific agent when creating the installation output. Now that the the Component kind exists the CLI should query for it in order to determine the version to add to the output of the install command.
The endpoint to use is: /apis/definitions/v1alpha1/components
The resource spec includes a latest object that looks like this
"latest": {
"version": "1.2.47",
"releaseDate": "2026-06-25T09:37:11.000+0000",
"endOfSupportDate": "2027-06-25T00:00:00.000+0000"
}
The CLI does, at this time, pull versions from jfrog. That should be removed as well. Output commands should reference repository.axway.com instead of axway.jfrog.io.