Feat/custom agents md instructions per repo or global - #142
Open
ArnabChatterjee20k wants to merge 17 commits into
Open
Feat/custom agents md instructions per repo or global#142ArnabChatterjee20k wants to merge 17 commits into
ArnabChatterjee20k wants to merge 17 commits into
Conversation
Greptile SummaryThe PR adds global and repository-scoped operator instructions, persists them in SQLite, injects them into agent contexts, and exposes administrative editors.
Confidence Score: 4/5The PR is not yet safe to merge because instruction lookup failures still let agent runs proceed without required operator constraints. The instruction helper catches storage failures and returns the unmodified context, so any affected run continues without the configured global or repository behavior. Files Needing Attention: crates/claudear-engine/src/processing.rs Important Files Changed
Reviews (8): Last reviewed commit: "fix(dashboard): don't show Saved for unp..." | Re-trigger Greptile |
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
ArnabChatterjee20k
force-pushed
the
feat/custom-agents-md-instructions-per-repo-or-global
branch
from
August 16, 2026 10:06
b38c248 to
862e212
Compare
| format!("{block}\n\n{context}") | ||
| } | ||
| } | ||
| _ => context, |
There was a problem hiding this comment.
When instruction resolution returns a storage error, this catch-all arm continues with the original context, causing the agent to run without configured operator constraints and without surfacing the failure.
Prompt To Fix With AI
This is a comment left during a code review.
Path: crates/claudear-engine/src/processing.rs
Line: 2810
Comment:
**Instruction lookup failures bypass constraints**
When instruction resolution returns a storage error, this catch-all arm continues with the original context, causing the agent to run without configured operator constraints and without surfacing the failure.
---
For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.
Global and per-repo operator instruction storage. Register V10 and update migrator test to v10.
Scope-namespaced upsert and getters plus resolve_agent_instructions which concatenates global then per-repo. Wired through KnowledgeStore.
prepend_operator_instructions applied on the fix, red, verify and reply paths. Prompt-string only, never touches repo files.
Global instructions apply even with no resolved repo. Per-repo header only when a repo is present.
Drop the early return that skipped global instructions when the repo was unresolved, and inject on the QA answer path.
Disable editing on a failed load to avoid overwriting, and show save failures instead of silently swallowing them.
Separate the PUT from cache revalidation. On success, optimistically sync the cache with revalidate:false so a failed background GET no longer reports a failed save, keeps the draft dirty, or blanks the editor.
ArnabChatterjee20k
force-pushed
the
feat/custom-agents-md-instructions-per-repo-or-global
branch
from
August 16, 2026 10:17
862e212 to
6ad97e3
Compare
Warn on a storage error instead of silently continuing, so a failed instruction resolution is visible while still failing open.
Capture the saved value and only clear the draft when it is unchanged, so edits typed during the PUT are not discarded.
Comment on lines
+403
to
+404
| setSaved(true) | ||
| setTimeout(() => setSaved(false), 3000) |
There was a problem hiding this comment.
When an administrator continues typing while the PUT is in flight, save completion preserves the newer draft but unconditionally sets saved to true. The editor consequently displays “Saved” and suppresses “Unsaved changes” for text that was never persisted; the repository editor repeats the same transition.
Prompt To Fix With AI
This is a comment left during a code review.
Path: dashboard/src/pages/config.tsx
Line: 403-404
Comment:
**Newer draft falsely marked saved**
When an administrator continues typing while the PUT is in flight, save completion preserves the newer draft but unconditionally sets `saved` to true. The editor consequently displays “Saved” and suppresses “Unsaved changes” for text that was never persisted; the repository editor repeats the same transition.
---
For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.Gate the Saved indicator on !dirty so edits typed during the PUT surface as Unsaved changes instead of a false Saved.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
(Provide a description of what this PR does.)
Test Plan
(Write your test plan here. If you changed any code, please provide us with clear instructions on how you verified your changes work.)
Related PRs and Issues
(If this PR is related to any other PR or resolves any issue or related to any issue link all related PR and issues here.)
Have you read the Contributing Guidelines on issues?
(Write your answer here.)