fix: show Appwrite icon for CLI OAuth consent avatars - #3161
Merged
Conversation
The first-party appwrite-cli client registers a wide wordmark as logoUri. Consent/outcome avatars use a square crop, so object-fit:cover left an unreadable fragment that looked like a missing logo (#3159). Prefer the square mark for that client and contain-fit other logos in the avatar. Co-authored-by: chiragaggarwal5k <chiragaggarwal5k@gmail.com>
Console (appwrite/console)Project ID: Sites (1)
Tip Environment variables can be scoped per function or shared across your project |
Contributor
Greptile SummaryThe PR updates OAuth consent and outcome avatars to show a square Appwrite icon for the CLI and preserve other application logos without cropping.
Confidence Score: 5/5The PR appears safe to merge. No blocking failure remains. Important Files Changed
Reviews (3): Last reviewed commit: "Revert "Fix the cropped logo with CSS in..." | Re-trigger Greptile |
The avatar used object-fit: cover, which crops a wide wordmark into an
unreadable fragment. Switching to contain fixes that for every client, so
the appwrite-cli special case and its resolver helper are unnecessary.
Hardcoding the CLI's client ID in the console was also the wrong layer:
logoUri is server-owned app-registry data, so a square mark belongs in the
registration upstream. Worse, app IDs are user-supplied, so anyone able to
create an OAuth app on a self-hosted instance could claim `appwrite-cli`
and render official Appwrite branding on a consent screen.
The helper's trim/?? '' normalization was dead too: the {#if} already
covered empty and undefined, and cimdDocumentToApp gates logoUri through
HTTP_URL before it ever reaches the template.
Fold the rule into .avatar rather than a separate img.avatar block. Every
other .avatar is a flex-centered div, so object-fit is inert there and the
padding stays harmless.
This reverts commit d049860.
HarshMN2345
approved these changes
Aug 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes the cropped/unreadable Appwrite logo on the CLI OAuth consent and "Device connected" screens (
appwrite login --new).The first-party
appwrite-cliclient registers a wide wordmark aslogoUri. Consent/outcome avatars are square and previously usedobject-fit: cover, which cropped the wordmark into an unreadable fragment that looked like a missing logo.Changes:
/logos/appwrite-icon.svgmark forappwrite-cliobject-fit: containfor app logo avatars so other wordmarks stay readableTest Plan
bun run test:unit src/lib/helpers/oauth2-app-logo.test.tsappwrite login --newand confirm the consent + device-connected screens show the pink Appwrite icon cleanlyRelated PRs and Issues
Checklist