fix: pass cluster_name_prod to deploy-to-prod job#19
Open
mawbid wants to merge 1 commit into
Open
Conversation
The deploy-to-prod job in release-deploy.yml was passing cluster_name_staging as CLUSTER_NAME instead of cluster_name_prod. CLUSTER_NAME is used by the force-new-deployment and wait-for-stable steps in deploy-ecs-service, so enabling FORCE_NEW_DEPLOYMENT on a release deploy would target the wrong cluster.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #18.
The
deploy-to-prodjob inrelease-deploy.ymlwas passingcluster_name_stagingasCLUSTER_NAMEinstead ofcluster_name_prod.CLUSTER_NAMEis only used by theforce-new-deploymentandwait services-stablesteps indeploy-ecs-service, and those steps are currently skipped becauseFORCE_NEW_DEPLOYMENTdefaults tofalse. The bug is latent — but enablingFORCE_NEW_DEPLOYMENTon a release deploy would target the staging cluster instead of prod.One-line change:
cluster_name_staging→cluster_name_prodon theCLUSTER_NAMEinput of the prod deployment step.