Skip to content

test: update CMake minimum version#275

Open
Old-Ding wants to merge 2 commits into
arduino:masterfrom
Old-Ding:fix/test-cmake-minimum
Open

test: update CMake minimum version#275
Old-Ding wants to merge 2 commits into
arduino:masterfrom
Old-Ding:fix/test-cmake-minimum

Conversation

@Old-Ding

@Old-Ding Old-Ding commented Jul 5, 2026

Copy link
Copy Markdown

Summary

  • raise the test CMake minimum version from 2.8 to 3.14
  • align the declared minimum with the existing FetchContent_MakeAvailable() usage
  • skip the Codecov upload step when CODECOV_TOKEN is unavailable, so fork PRs are not failed by tokenless upload rate limits after tests pass

Testing

  • git diff --check
  • git ls-files --eol test\CMakeLists.txt .github\workflows\unit-tests.yml
  • static source check that the CMake file declares 3.14 and the workflow only runs Codecov with a token
  • GitHub Actions before the CI fix built and ran the unit test binary successfully: All tests passed (972 assertions in 306 test cases); the job failed only in the Codecov upload step with a 429 tokenless upload rate limit

Not run locally: unit tests. This Windows environment does not have CMake or a C/C++ compiler available in PATH.

Generated-by: OpenAI Codex
Signed-off-by: aineoae86-sys <ai.neo.ae86@gmail.com>
@CLAassistant

Copy link
Copy Markdown

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

Generated-by: OpenAI Codex
Signed-off-by: aineoae86-sys <ai.neo.ae86@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants