Mobile Shell Button by arul28 · Pull Request #723 · arul28/ADE

arul28 · 2026-07-07T19:47:02Z

Summary

Describe the change.

What Changed

Key files and behaviors.

Validation

How you tested.

Risks

Anything to watch.

Open in ADE · ade/ok-start-skill-plan-skill-77039123 branch · PR #723

Summary by CodeRabbit

New Features
- Added a new way to start shell sessions from chat, with project-aware scope selection.
- Improved session launching so the app can route commands to the correct project context, even when offline or queued.
Bug Fixes
- Fixed session launches so they keep the intended project scope instead of switching to the active project.
- Improved handling of queued shell launches to avoid failed or misrouted sessions.

Greptile Summary

This PR adds a mobile Shell button for work lanes. The main changes are:

Lane project IDs now flow into local lane summaries.
Shell launches resolve scope from the selected lane.
Shell commands avoid active-project fallback when lane scope is missing.
The Work composer shows a Shell chip next to import actions.
Tests cover shell defaults, nested roots, stale catalogs, and queued shell starts.

Confidence Score: 5/5

This looks safe to merge.

No blocking issues found in the changed code.

T-Rex Logs

What T-Rex did

Reviewed the general-contract-validation-proof for the mobile-shell-button tooling, noting the two associated logs.
Reviewed the tooling check log to verify that the pre-build checks completed as expected.
Reviewed the attempted iOS build log to capture the build context after tooling validation.

_{Ran code and verified through T-Rex}

Important Files Changed

Filename	Overview
apps/ios/ADE/Views/Work/WorkNewChatScreen.swift	Adds the Shell chip and resolves shell project scope from the selected lane.
apps/ios/ADE/Services/SyncService.swift	Adds shell-specific session creation and carries the active-project fallback flag through command send, queue, and replay paths.
apps/ios/ADE/Services/Database.swift	Loads lane project IDs from the local lane table into lane summaries.
apps/ios/ADE/Models/RemoteModels.swift	Adds an optional project ID field to lane summaries.
apps/ios/ADETests/ADETests.swift	Adds tests for shell request defaults, lane scope resolution, and queued shell behavior.

_{Reviews (8): Last reviewed commit: "ship: iteration 7 - reject stale parent ..." | Re-trigger Greptile}

vercel · 2026-07-07T19:47:03Z

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment

Project	Deployment	Actions	Updated (UTC)
ade	Ignored	Preview	Jul 7, 2026 9:10pm

cursor · 2026-07-07T19:47:07Z

Bugbot is not enabled for your account, so this pull request was not reviewed.

Enable Bugbot in the Cursor dashboard to get automatic reviews on future PRs.

coderabbitai · 2026-07-07T19:47:11Z

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: bf6bf2bd-2531-4085-89ad-eaf076bbd7de

📥 Commits

Reviewing files that changed from the base of the PR and between 3147479 and f59ecc4.

📒 Files selected for processing (7)

apps/ios/ADE/Models/RemoteModels.swift
apps/ios/ADE/Services/Database.swift
apps/ios/ADE/Services/SyncService.swift
apps/ios/ADE/Views/Work/WorkNewChatScreen.swift
apps/ios/ADE/Views/Work/WorkPreviews.swift
apps/ios/ADE/Views/Work/WorkRootScreen.swift
apps/ios/ADETests/ADETests.swift

📝 Walkthrough

Walkthrough

This PR adds shell session launch capability with project scoping to the iOS app. LaneSummary and LaneRow gain a projectId field. SyncService introduces startShellSession/WorkStartShellSessionRequest and a fallbackToActiveProjectScope flag threaded through command sending, queuing, and replay. WorkNewChatScreen adds scope resolution and shell launch UI/state, with corresponding tests.

Changes

Project-scoped shell session launch

Layer / File(s)	Summary
Lane and database project identifier plumbing `apps/ios/ADE/Models/RemoteModels.swift`, `apps/ios/ADE/Services/Database.swift`	`LaneSummary` and `LaneRow` add an optional `projectId`; `fetchLanesLocked` selects and hydrates `project_id`.
SyncService shell session API and scope-aware command routing `apps/ios/ADE/Services/SyncService.swift`	Adds `WorkStartShellSessionRequest`/`startShellSession`; extends `startCliSession`, `sendDecodableCommand`, `sendCommand`, `enqueueOperation`, `performCommandRequest`, and `PendingOperation` with `fallbackToActiveProjectScope` for scope resolution and queued replay.
WorkNewChatScreen shell launch UI and scope resolution `apps/ios/ADE/Views/Work/WorkNewChatScreen.swift`, `apps/ios/ADE/Views/Work/WorkRootScreen.swift`, `apps/ios/ADE/Views/Work/WorkPreviews.swift`	Adds `WorkProjectCommandScope`/`workShellProjectScope`, `activeProjectRootPath` input, shell busy/queued state, chip UI, `launchShell(in:)`, and shell tool-type mapping; call sites pass `activeProjectRootPath`.
Tests for shell scope resolution and queued start behavior `apps/ios/ADETests/ADETests.swift`	Adds tests for `workStartShellSessionRequest` defaults, `workShellProjectScope` matching rules, and queued/failing `startShellSession` async behavior.

Estimated code review effort: 4 (Complex) | ~60 minutes

Possibly related PRs

arul28/ADE#255: Both PRs implement the “start CLI session” flow end-to-end, including SyncService.startCliSession/startShellSession plumbing and queued/persisted replay for work.startCliSession.
arul28/ADE#574: Both PRs modify SyncService.swift's queued/pending-remote-command behavior, specifically sendCommand/command request handling and queued operation retention/replay.

Suggested labels: ios

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title matches the main change: adding a mobile Shell launcher/button to work lanes.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

✨ Finishing Touches

📝 Generate docstrings

Create stacked PR
Commit on current branch

🧪 Generate unit tests (beta)

Create PR with unit tests
Commit unit tests in branch ade/ok-start-skill-plan-skill-77039123

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands.}

arul28 · 2026-07-07T19:47:20Z

@copilot review but do not make fixes

arul28 · 2026-07-07T20:04:23Z

@codex review

chatgpt-codex-connector · 2026-07-07T20:08:30Z

Codex Review: Didn't find any major issues. 🚀

Reviewed commit: 04607204c1

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

arul28 · 2026-07-07T20:22:54Z

@codex review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: c12c170029

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

arul28 · 2026-07-07T20:35:16Z

@codex review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 5dd7ca1fba

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

arul28 · 2026-07-07T20:45:33Z

@codex review

chatgpt-codex-connector · 2026-07-07T20:45:40Z

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.
To continue using code reviews, add credits to your account and enable them for code reviews in your settings.

cursor · 2026-07-07T20:53:13Z

Bugbot is not enabled for your account, so this pull request was not reviewed.

Enable Bugbot in the Cursor dashboard to get automatic reviews on future PRs.

Add mobile shell launcher

5dc4251

greptile-apps Bot reviewed Jul 7, 2026

View reviewed changes

Comment thread apps/ios/ADE/Views/Work/WorkNewChatScreen.swift

ship: iteration 1 - address shell scope review

0460720

greptile-apps Bot reviewed Jul 7, 2026

View reviewed changes

Comment thread apps/ios/ADE/Views/Work/WorkNewChatScreen.swift Outdated

ship: iteration 2 - derive shell scope from lane

c12c170

greptile-apps Bot reviewed Jul 7, 2026

View reviewed changes

Comment thread apps/ios/ADE/Views/Work/WorkNewChatScreen.swift Outdated

chatgpt-codex-connector Bot reviewed Jul 7, 2026

View reviewed changes

Comment thread apps/ios/ADE/Views/Work/WorkNewChatScreen.swift Outdated

ship: iteration 3 - harden queued shell launches

5dd7ca1

chatgpt-codex-connector Bot reviewed Jul 7, 2026

View reviewed changes

Comment thread apps/ios/ADE/Services/SyncService.swift

ship: iteration 4 - require shell project scope

16a4259

greptile-apps Bot reviewed Jul 7, 2026

View reviewed changes

Comment thread apps/ios/ADE/Views/Work/WorkNewChatScreen.swift

ship: iteration 5 - prefer nested shell scope

1c1e786

greptile-apps Bot reviewed Jul 7, 2026

View reviewed changes

Comment thread apps/ios/ADE/Views/Work/WorkNewChatScreen.swift Outdated

ship: iteration 6 - keep known shell project

5bf46f6

greptile-apps Bot reviewed Jul 7, 2026

View reviewed changes

Comment thread apps/ios/ADE/Views/Work/WorkNewChatScreen.swift Outdated

ship: iteration 7 - reject stale parent shell scope

f59ecc4

arul28 merged commit ec97350 into main Jul 7, 2026
33 checks passed

arul28 deleted the ade/ok-start-skill-plan-skill-77039123 branch July 7, 2026 21:20

Conversation

arul28 commented Jul 7, 2026 • edited by greptile-apps Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

What Changed

Validation

Risks

Summary by CodeRabbit

Greptile Summary

Confidence Score: 5/5

T-Rex Logs

Important Files Changed

Uh oh!

vercel Bot commented Jul 7, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

cursor Bot commented Jul 7, 2026

Uh oh!

coderabbitai Bot commented Jul 7, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Uh oh!

arul28 commented Jul 7, 2026

Uh oh!

Uh oh!

arul28 commented Jul 7, 2026

Uh oh!

chatgpt-codex-connector Bot commented Jul 7, 2026

Uh oh!

Uh oh!

arul28 commented Jul 7, 2026

Uh oh!

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

arul28 commented Jul 7, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

arul28 commented Jul 7, 2026

Uh oh!

chatgpt-codex-connector Bot commented Jul 7, 2026

Uh oh!

Uh oh!

cursor Bot commented Jul 7, 2026

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

arul28 commented Jul 7, 2026 •

edited by greptile-apps Bot

Loading

vercel Bot commented Jul 7, 2026 •

edited

Loading

coderabbitai Bot commented Jul 7, 2026 •

edited

Loading