Start Skill Mobile Prs View#729
Conversation
|
Bugbot is not enabled for your account, so this pull request was not reviewed. Enable Bugbot in the Cursor dashboard to get automatic reviews on future PRs. |
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
|
Warning Review limit reached
Next review available in: 4 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (10)
📝 WalkthroughWalkthroughThis PR introduces PR lifecycle notification kinds (opened, reopened, closed, merged) across the desktop polling service, shared types, and toast presentation. The ade-cli push publisher now tracks and expires PR activity for iOS Live Activity content state. iOS ActivityKit attributes gain a PullRequest model, and the widget/PR detail screens are updated to render PR rows, a new summary section with commit expansion, and timeline scroll-to-commit navigation, alongside a markdown normalization refactor. Changesade-cli push publisher PR lifecycle support
Desktop PR lifecycle notification kinds
iOS ActivityKit PR content state and widget rendering
iOS PR detail markdown normalization and summary/timeline UI
Estimated code review effort: 4 (Complex) | ~60 minutes Possibly related PRs
Suggested labels: 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 inconclusive)
✅ Passed checks (4 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
@copilot review but do not make fixes |
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
|
@codex review |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 19eeda873b
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: d33450b8ea
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 3
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@apps/ade-cli/src/services/push/pushPublisherService.ts`:
- Around line 588-589: The start alert in PushPublisherService undercounts PR
activity because prActivityCount is taken from contentState.prs.length, which is
capped. Update the start-alert count in pushPublisherService to use the uncapped
total from contentState.activeCount (or the equivalent uncapped source already
used in the run path) so the `${prActivityCount} pull requests updated` message
reflects the real number when more than two PRs are tracked.
In `@apps/desktop/src/main/services/prs/prPollingService.ts`:
- Around line 309-318: The polling flow in prPollingService is clearing tracked
PR state on a transient empty poll, which causes the next non-empty poll to
reclassify existing PRs as newly opened. Update the snapshot management around
the polling/refresh logic that feeds lastByPrId so an empty discovery tick does
not overwrite the previous map while initialized remains true; only reset the
stored PR set when the polling state is intentionally reinitialized.
In `@apps/ios/ADE/Views/PRs/PrDetailScreen.swift`:
- Around line 1096-1107: The event matching in PrDetailScreen.eventMatches can
falsely match any .commit event when both commit.shortSha and commit.sha are
empty because the search string becomes empty. Update eventMatches to explicitly
return false when there is no usable SHA (before checking
localizedCaseInsensitiveContains), and keep matching only against non-empty
shortSha/fullSha so focusCommitInTimeline doesn’t scroll to the wrong timeline
row.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: 7a98ddba-b9c5-48f9-8db0-f8b85e786b66
⛔ Files ignored due to path filters (2)
docs/features/pull-requests/README.mdis excluded by!docs/**docs/features/sync-and-multi-device/ios-companion.mdis excluded by!docs/**
📒 Files selected for processing (14)
apps/ade-cli/src/bootstrap.tsapps/ade-cli/src/services/push/pushPublisherService.test.tsapps/ade-cli/src/services/push/pushPublisherService.tsapps/desktop/src/main/services/prs/prPollingService.tsapps/desktop/src/renderer/components/app/prToastPresentation.tsapps/desktop/src/shared/types/prs.tsapps/ios/ADE/Shared/ADEAgentActivityAttributes.swiftapps/ios/ADE/Views/PRs/CreatePrWizardView.swiftapps/ios/ADE/Views/PRs/PrDetailActivityTab.swiftapps/ios/ADE/Views/PRs/PrDetailOverviewTab.swiftapps/ios/ADE/Views/PRs/PrDetailScreen.swiftapps/ios/ADE/Views/PRs/PrHelpers.swiftapps/ios/ADETests/ADETests.swiftapps/ios/ADEWidgets/ADEAgentActivityWidget.swift
|
Deployment failed with the following error: Learn More: https://vercel.com/arul28s-projects?upgradeToPro=build-rate-limit |
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 2dce34e68f
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
Bugbot is not enabled for your account, so this pull request was not reviewed. Enable Bugbot in the Cursor dashboard to get automatic reviews on future PRs. |
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 006ea879bc
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
@codex review |
1 participant
Summary
Describe the change.
What Changed
Key files and behaviors.
Validation
How you tested.
Risks
Anything to watch.
Summary by CodeRabbit
New Features
Bug Fixes
Greptile Summary
This PR adds PR lifecycle notifications and a richer mobile PR view. The main changes are:
Confidence Score: 4/5
The repo-scoped PR navigation path can still open or hydrate the wrong PR.
The push payload now carries owner and repo, but the iOS detail screen drops that scope during reload, and the fallback GitHub lookup still matches duplicate PR numbers across repositories.
apps/ios/ADE/Views/PRs/PrDetailScreen.swift
What T-Rex did
Important Files Changed
Comments Outside Diff (2)
apps/ios/ADE/Views/PRs/PrDetailScreen.swift, line 1303-1308 (link)When a repo-scoped PR notification opens a synthetic
github-pr-number:<n>route, this reload path callsprDetailRouteListItemwithout the requested owner and repo. If two tracked repositories both have PR#42, a later reload can resolve only by number and leave the detail screen on the wrong PR or no PR.Prompt To Fix With AI
apps/ios/ADE/Views/PRs/PrDetailScreen.swift, line 1445-1450 (link)The fallback GitHub item lookup scans all repo PRs and accepts the first matching
githubPrNumberwithout checking the scoped owner and repo. Tapping a notification forownerA/repoA#42can hydrate the detail screen withownerB/repoB#42when that item appears first.Prompt To Fix With AI
Prompt To Fix All With AI
Reviews (5): Last reviewed commit: "ship: iteration 4 address PR activity id..." | Re-trigger Greptile