compact-permission-steering-boxes -> Primary#801
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
|
@copilot review but do not make fixes |
📝 WalkthroughWalkthroughChangesComposer and reasoning UI
Estimated code review effort: 3 (Moderate) | ~20 minutes Possibly related PRs
Suggested labels: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@apps/desktop/src/renderer/index.css`:
- Around line 4165-4170: Directional effort-word animations are not disabled for
users who prefer reduced motion. Update the reduced-motion handling for
.ade-reasoning-effort-word[data-direction="up"] and [data-direction="down"], or
gate their animations with prefers-reduced-motion: no-preference while
preserving the existing animation behavior otherwise.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: 7d0b7072-9c79-48b7-9807-8a13c617441b
⛔ Files ignored due to path filters (1)
docs/features/chat/README.mdis excluded by!docs/**
📒 Files selected for processing (5)
apps/desktop/src/renderer/components/chat/AgentChatComposer.test.tsxapps/desktop/src/renderer/components/chat/AgentChatComposer.tsxapps/desktop/src/renderer/components/shared/ModelPicker/ReasoningEffortPicker.test.tsxapps/desktop/src/renderer/components/shared/ModelPicker/ReasoningEffortPicker.tsxapps/desktop/src/renderer/index.css
|
@codex review |
|
Codex Review: Didn't find any major issues. 🚀 Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
Summary by CodeRabbit
UI Improvements
Bug Fixes
Greptile Summary
This PR updates compact chat composer controls and reasoning-effort label motion. The main changes are:
Confidence Score: 5/5
Safe to merge with minimal risk.
The changes are localized UI updates with tests covering the modified interactions. No correctness or security issues were identified in the changed paths.
No files require special attention.
What T-Rex did
Important Files Changed
Sequence Diagram
%%{init: {'theme': 'neutral'}}%% sequenceDiagram participant User participant Composer as AgentChatComposer participant Permission as PermissionModePicker participant Send as ActiveTurnSendButton participant Reasoning as ReasoningEffortPicker participant CSS as index.css animations User->>Composer: Open compact permission/send menus Composer->>Permission: Render 240px title-only options Composer->>Send: Render 240px concise send options User->>Reasoning: Select a different effort tier Reasoning->>Reasoning: Compare activeIndex with previousActiveIndexRef Reasoning->>CSS: Set data-direction up/down/idle CSS-->>User: Play directional roll animation%%{init: {'theme': 'base', 'themeVariables': {"darkMode": true, "background": "#0d1117", "primaryColor": "#21262d", "primaryTextColor": "#e6edf3", "primaryBorderColor": "#8b949e", "lineColor": "#8b949e", "textColor": "#e6edf3", "edgeLabelBackground": "#161b22", "actorBkg": "#21262d", "actorBorder": "#8b949e", "actorTextColor": "#e6edf3", "actorLineColor": "#8b949e", "signalColor": "#8b949e", "signalTextColor": "#e6edf3", "noteBkgColor": "#373320", "noteBorderColor": "#d4a72c", "noteTextColor": "#f0e6c0", "labelBoxBkgColor": "#21262d", "labelBoxBorderColor": "#8b949e", "labelTextColor": "#e6edf3", "loopTextColor": "#e6edf3", "activationBkgColor": "#30363d", "activationBorderColor": "#8b949e"}}}%% sequenceDiagram participant User participant Composer as AgentChatComposer participant Permission as PermissionModePicker participant Send as ActiveTurnSendButton participant Reasoning as ReasoningEffortPicker participant CSS as index.css animations User->>Composer: Open compact permission/send menus Composer->>Permission: Render 240px title-only options Composer->>Send: Render 240px concise send options User->>Reasoning: Select a different effort tier Reasoning->>Reasoning: Compare activeIndex with previousActiveIndexRef Reasoning->>CSS: Set data-direction up/down/idle CSS-->>User: Play directional roll animationReviews (2): Last reviewed commit: "ship: iteration 1 — respect reduced moti..." | Re-trigger Greptile