Skip to content

compact-permission-steering-boxes -> Primary#801

Merged
arul28 merged 2 commits into
mainfrom
ade/ok-start-skill-want-some-bf1f5854
Jul 13, 2026
Merged

compact-permission-steering-boxes -> Primary#801
arul28 merged 2 commits into
mainfrom
ade/ok-start-skill-want-some-bf1f5854

Conversation

@arul28

@arul28 arul28 commented Jul 13, 2026

Copy link
Copy Markdown
Owner

ADE   Open in ADE  ·  ade/ok-start-skill-want-some-bf1f5854 branch  ·  PR #801

Summary by CodeRabbit

  • UI Improvements

    • Compact Claude permission and send-option menus now fit better in smaller layouts.
    • Updated menu spacing, sizing, typography, and descriptions for improved readability.
    • Reasoning effort labels now animate directionally when switching between levels.
    • Removed the unnecessary help icon from the reasoning effort picker.
  • Bug Fixes

    • Improved consistency and presentation of dropdown and picker interactions across the chat composer.

Greptile Summary

This PR updates compact chat composer controls and reasoning-effort label motion. The main changes are:

  • Compacts Claude permission and active-turn send option menus.
  • Shortens send-option descriptions for smaller layouts.
  • Adds directional up/down animation data for reasoning effort label changes.
  • Replaces the reasoning label pop animation with directional roll animations.
  • Adds tests for the compact menus and reasoning label transition direction.
  • Updates chat feature documentation for the reasoning picker animation.

Confidence Score: 5/5

Safe to merge with minimal risk.

The changes are localized UI updates with tests covering the modified interactions. No correctness or security issues were identified in the changed paths.

No files require special attention.

T-Rex T-Rex Logs

What T-Rex did

  • The desktop UI devserver started with the Vite renderer, performed a fallback mock-data export, published a ready URL, and was subsequently terminated.
  • A Playwright capture run was executed to load the renderer, but navigation failed due to a refused connection.
  • The component tests were updated and now pass, including the compact menu and reasoning effort picker behavior.

View all artifacts

T-Rex Ran code and verified through T-Rex

Important Files Changed

Filename Overview
apps/desktop/src/renderer/components/chat/AgentChatComposer.test.tsx Adds tests for compact Claude steering and permission menus.
apps/desktop/src/renderer/components/chat/AgentChatComposer.tsx Compacts permission and active-turn send dropdown layout and copy.
apps/desktop/src/renderer/components/shared/ModelPicker/ReasoningEffortPicker.test.tsx Adds controlled-picker coverage for directional reasoning effort label transitions.
apps/desktop/src/renderer/components/shared/ModelPicker/ReasoningEffortPicker.tsx Tracks previous reasoning tier index to set up, down, or idle transition direction.
apps/desktop/src/renderer/index.css Adds directional reasoning label roll animations and reduced-motion handling.
docs/features/chat/README.md Updates chat feature docs for the reasoning picker directional roll transition.

Sequence Diagram

%%{init: {'theme': 'neutral'}}%%
sequenceDiagram
participant User
participant Composer as AgentChatComposer
participant Permission as PermissionModePicker
participant Send as ActiveTurnSendButton
participant Reasoning as ReasoningEffortPicker
participant CSS as index.css animations

User->>Composer: Open compact permission/send menus
Composer->>Permission: Render 240px title-only options
Composer->>Send: Render 240px concise send options
User->>Reasoning: Select a different effort tier
Reasoning->>Reasoning: Compare activeIndex with previousActiveIndexRef
Reasoning->>CSS: Set data-direction up/down/idle
CSS-->>User: Play directional roll animation
Loading
%%{init: {'theme': 'base', 'themeVariables': {"darkMode": true, "background": "#0d1117", "primaryColor": "#21262d", "primaryTextColor": "#e6edf3", "primaryBorderColor": "#8b949e", "lineColor": "#8b949e", "textColor": "#e6edf3", "edgeLabelBackground": "#161b22", "actorBkg": "#21262d", "actorBorder": "#8b949e", "actorTextColor": "#e6edf3", "actorLineColor": "#8b949e", "signalColor": "#8b949e", "signalTextColor": "#e6edf3", "noteBkgColor": "#373320", "noteBorderColor": "#d4a72c", "noteTextColor": "#f0e6c0", "labelBoxBkgColor": "#21262d", "labelBoxBorderColor": "#8b949e", "labelTextColor": "#e6edf3", "loopTextColor": "#e6edf3", "activationBkgColor": "#30363d", "activationBorderColor": "#8b949e"}}}%%
sequenceDiagram
participant User
participant Composer as AgentChatComposer
participant Permission as PermissionModePicker
participant Send as ActiveTurnSendButton
participant Reasoning as ReasoningEffortPicker
participant CSS as index.css animations

User->>Composer: Open compact permission/send menus
Composer->>Permission: Render 240px title-only options
Composer->>Send: Render 240px concise send options
User->>Reasoning: Select a different effort tier
Reasoning->>Reasoning: Compare activeIndex with previousActiveIndexRef
Reasoning->>CSS: Set data-direction up/down/idle
CSS-->>User: Play directional roll animation
Loading

Reviews (2): Last reviewed commit: "ship: iteration 1 — respect reduced moti..." | Re-trigger Greptile

@vercel

vercel Bot commented Jul 13, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Actions Updated (UTC)
ade Ignored Ignored Preview Jul 13, 2026 6:54pm

@arul28

arul28 commented Jul 13, 2026

Copy link
Copy Markdown
Owner Author

@copilot review but do not make fixes

@coderabbitai

coderabbitai Bot commented Jul 13, 2026

Copy link
Copy Markdown

Review Change Stack

📝 Walkthrough

Walkthrough

Changes

Composer and reasoning UI

Layer / File(s) Summary
Compact composer menus
apps/desktop/src/renderer/components/chat/AgentChatComposer.tsx, apps/desktop/src/renderer/components/chat/AgentChatComposer.test.tsx
Claude permission and active-turn send menus now share a compact width, updated spacing, typography, copy, and coverage for their rendered contents.
Directional reasoning-effort transitions
apps/desktop/src/renderer/components/shared/ModelPicker/ReasoningEffortPicker.tsx, apps/desktop/src/renderer/components/shared/ModelPicker/ReasoningEffortPicker.test.tsx, apps/desktop/src/renderer/index.css
Reasoning-effort changes now expose upward or downward direction metadata and use matching roll animations, with tests covering High and Low selections.

Estimated code review effort: 3 (Moderate) | ~20 minutes

Possibly related PRs

  • arul28/ADE#789: Updates the related Claude active-turn steering and composer menu experience.

Suggested labels: desktop, docs

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title is related to the compact permission/steering menu changes, even though it is awkward and only covers part of the PR.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch ade/ok-start-skill-want-some-bf1f5854

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@apps/desktop/src/renderer/index.css`:
- Around line 4165-4170: Directional effort-word animations are not disabled for
users who prefer reduced motion. Update the reduced-motion handling for
.ade-reasoning-effort-word[data-direction="up"] and [data-direction="down"], or
gate their animations with prefers-reduced-motion: no-preference while
preserving the existing animation behavior otherwise.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 7d0b7072-9c79-48b7-9807-8a13c617441b

📥 Commits

Reviewing files that changed from the base of the PR and between ce7d370 and 57ea8bb.

⛔ Files ignored due to path filters (1)
  • docs/features/chat/README.md is excluded by !docs/**
📒 Files selected for processing (5)
  • apps/desktop/src/renderer/components/chat/AgentChatComposer.test.tsx
  • apps/desktop/src/renderer/components/chat/AgentChatComposer.tsx
  • apps/desktop/src/renderer/components/shared/ModelPicker/ReasoningEffortPicker.test.tsx
  • apps/desktop/src/renderer/components/shared/ModelPicker/ReasoningEffortPicker.tsx
  • apps/desktop/src/renderer/index.css

Comment thread apps/desktop/src/renderer/index.css
@arul28

arul28 commented Jul 13, 2026

Copy link
Copy Markdown
Owner Author

@codex review

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. 🚀

Reviewed commit: 3d3e4c6089

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@arul28 arul28 merged commit 4a53bc2 into main Jul 13, 2026
33 checks passed
@arul28 arul28 deleted the ade/ok-start-skill-want-some-bf1f5854 branch July 13, 2026 19:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant