Restore the -lMass flag in the strict elastic beam parsers#5
Open
joecga4 wants to merge 1 commit into
Open
Conversation
The new strict optional-argument counting in the elasticBeamColumn / ElasticTimoshenkoBeam / ModElasticBeam3d parsers (numOptionalArgs + OPS_ResetCurrentInputArg(-numArgs)) recognizes -cMass but not the documented -lMass flag. An unrecognized token is not counted as an optional argument, so the positional-argument count comes out wrong and parsing fails or misreads arguments, e.g. element elasticBeamColumn 1 1 2 $A $E $Iz $transfTag -lMass -> WARNING transfTag is not integer ... expected integer but got "72.3" -lMass (lumped mass, the default) is accepted again as an explicit no-op, matching the pre-regression behavior. ElasticBeam2d gets the branch in both of its parsers. Also fixes a typo in EXAMPLES/verification/PortalFrame2d.tcl that this regression exposed: "$M &massType" -> "$M $massType" (two call sites); with the typo the literal string "&massType" was passed through and the suite aborted instead of reporting PASSED. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The strict optional-argument counting recently introduced in the
elasticBeamColumn/ElasticTimoshenkoBeam/ModElasticBeam3dparsers (numOptionalArgs+OPS_ResetCurrentInputArg(-numArgs)) recognizes-cMassbut not the documented-lMassflag. An unrecognized token is not counted as optional, so the positional-argument count comes out wrong and parsing fails or misreads arguments:This PR accepts
-lMassagain as an explicit no-op (lumped mass is the default), inElasticBeam2d(both parsers),ElasticBeam3d,ElasticTimoshenkoBeam2d/3dandModElasticBeam3d, matching the pre-regression behavior.It also fixes the typo in
EXAMPLES/verification/PortalFrame2d.tclthat this regression exposed:$M &massType→$M $massType(two call sites). With the typo, the literal string&massTypewas passed through and the verification suite aborted at PortalFrame2d.Validation:
runVerificationSuite.tclback to 18/18 PASSED (was aborting at PortalFrame2d); results byte-identical for the previously passing cases.🤖 Generated with Claude Code