Fix three small bugs in Actor's method-table handling#7
Closed
joecga4 wants to merge 1 commit into
Closed
Conversation
- Actor::processMethod() looked up actorMethods[tag] while iterating with i, so a method whose tag differs from its array position is found by the loop but the wrong entry (or out-of-bounds memory) is dereferenced. - ~Actor() used delete on an array allocated with new[], and never freed the ActorMethod objects added by addMethod(). - The constructor zero-initialized the array with a loop bounded by numMethods, which is 0 at that point; the bound is now maxNumMethods so the whole array starts null. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Actor::processMethod()indexedactorMethods[tag]while iterating withi, so a method whose tag differs from its array position is found by the loop but the wrong entry (or out-of-bounds memory) is dereferenced.~Actor()useddeleteon an array allocated withnew[], and never freed theActorMethodobjects added byaddMethod().numMethods, which is always 0 at that point; the bound is nowmaxNumMethodsso the whole array starts null.Validation: full build + pytest 7/7 + verification suite 18/18 byte-identical + MP/SP/PyMP MPI runs on Ubuntu 24.04.
🤖 Generated with Claude Code