ArmyFarmVoidAurasv2 & UltraDarkonv2 - #134
Open
tapsilog74 wants to merge 4 commits into
Open
Conversation
fix UltraDarkonv2 respawn after death
Reviewer's GuideAdds a new coordinated army farming script for Void Auras with shared private room and helper-mode behavior, and updates UltraDarkon to set a spawn point in the boss room so players respawn correctly after death. Sequence diagram for helper-mode army stage combat in ArmyFarmVoidAurasv2sequenceDiagram
participant Script as ArmyFarmVoidAurasv2
participant Ultra as CoreUltrav3
participant ArmyGen as ArmyGeneral
participant Core as CoreBots
participant Player as Bot_Player
Script->>Script: RetrieveVoidAuras(quant, useArmySync)
Script->>Script: GetOwnStage(essenceQuant)
Script->>ArmyGen: PublishAndGetArmyStage(Ultra, Bot, ownStage, stageSyncFile, armySize)
ArmyGen-->>Script: stageIndex
loop perStage
Script->>Ultra: CheckArmyProgressBool(() => Core.CheckInventory(stage.essence, essenceQuant), syncFile)
alt stageCompleteAndHelper
Script->>Script: RunStageCombat(stage, isHelper:true, useArmySync, ref stageSkillsEnabled)
Script->>Script: EnsureStageSkills(ref stageSkillsEnabled)
Script->>Script: JoinStageMap(stage.map)
Script->>Script: PrepareHelperPosition(stage)
Script->>Player: SetSpawnPoint()
Script->>Script: HelperAttack(stage)
else normalFarmer
Script->>Script: RunStageCombat(stage, isHelper:false, useArmySync, ref stageSkillsEnabled)
Script->>Script: FarmStage(stage, 100, useArmySync)
end
Script->>Script: ResetCombatOptions()
end
Sequence diagram for UltraDarkonv2 boss fight spawn handlingsequenceDiagram
participant Player as Player
participant Script as UltraDarkonv2_Fight
participant Ultra as CoreUltrav3
participant Core as CoreBots
Player->>Script: Fight()
Script->>Ultra: WaitForArmy(armySize-1, Ultra_Darkon.sync)
Script->>Core: ChooseBestCell(boss)
Script->>Player: SetSpawnPoint()
Script->>Core: EnableSkills()
rect rgb(230,230,230)
note over Player,Script: During fight
Player--xScript: Player dies
Script-->>Player: Respawn at SetSpawnPoint (boss room)
end
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
There was a problem hiding this comment.
Hey - I've found 1 issue, and left some high level feedback:
- The
RunStageCombatmethod takes auseArmySyncparameter that is never used; consider removing it from the signature and call sites to keep the API minimal and avoid confusion about its purpose. - The essence quantity target
100is hard-coded in multiple locations (e.g.,essenceQuant = 100inRetrieveVoidAurasand theFarmStage(stage, 100, ...)call); consider extracting this into a single named constant to reduce duplication and make future tuning easier.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- The `RunStageCombat` method takes a `useArmySync` parameter that is never used; consider removing it from the signature and call sites to keep the API minimal and avoid confusion about its purpose.
- The essence quantity target `100` is hard-coded in multiple locations (e.g., `essenceQuant = 100` in `RetrieveVoidAuras` and the `FarmStage(stage, 100, ...)` call); consider extracting this into a single named constant to reduce duplication and make future tuning easier.
## Individual Comments
### Comment 1
<location path="Army/ArmyFarmVoidAurasv2.cs" line_range="246-248" />
<code_context>
+ FarmStage(stage, 100, useArmySync);
+ }
+
+ private void EnsureStageSkills(ref bool stageSkillsEnabled)
+ {
+ if (stageSkillsEnabled || !Bot.Config!.Get<bool>("DoEnh"))
+ return;
+
</code_context>
<issue_to_address>
**issue (bug_risk):** Skill enabling is incorrectly gated by the `DoEnh` option, which can disable combat skills when enhancements are turned off.
Because this method returns when `DoEnh` is false, `Engine.EnableSkills()` is never called if the user disables enhancements, so stage combat skills won’t run and the bot may idle. Please decouple enhancement application from skill enabling (e.g., remove the `DoEnh` check here or introduce a separate config option for skill usage) so turning off enhancements doesn’t also disable combat skills.
</issue_to_address>Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Comment on lines
+246
to
+248
| private void EnsureStageSkills(ref bool stageSkillsEnabled) | ||
| { | ||
| if (stageSkillsEnabled || !Bot.Config!.Get<bool>("DoEnh")) |
There was a problem hiding this comment.
issue (bug_risk): Skill enabling is incorrectly gated by the DoEnh option, which can disable combat skills when enhancements are turned off.
Because this method returns when DoEnh is false, Engine.EnableSkills() is never called if the user disables enhancements, so stage combat skills won’t run and the bot may idle. Please decouple enhancement application from skill enabling (e.g., remove the DoEnh check here or introduce a separate config option for skill usage) so turning off enhancements doesn’t also disable combat skills.
Collaborator
|
go to the discord, in the #skua-script-reports channel, make a post and @tato if you want this merged. make sure u explain why and such |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ArmyFarmVoidAurasv2
Added
UltraDarkonv2
Tested on Skua 1.4.4.0
Tested on VibeSkua 1.8.3
Summary by Sourcery
Add an army-coordinated Void Aura farming script with shared private rooms and helper behavior, and improve Ultra Darkon to respawn back in the boss room after death.
New Features:
Bug Fixes: