fix: exclude test files from the published build#276
Open
ivanauth wants to merge 3 commits into
Open
Conversation
Excluding tests in the shared tsconfig broke the js-client CI job, which builds with build-js-client into js-dist and runs vitest there against the emitted test files. Keep tests in the default project (editor and js-dist unchanged) and add tsconfig.build.json, used by the build script, to exclude them from dist/ and the published package.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #161.
*.test.ts files were compiled into dist/ and published to npm. The
tsconfig exclude pattern was
src/**/*.test.*/*, whose trailing/*only matches files inside a directory named like
*.test.*(neverexists), so it excluded nothing.
Fixing the glob alone would break the
build-js-clientCI job, whichcompiles into js-dist/ and runs the tests there. So this splits the
config:
editor type-checking and the build-js-client CI job.
src/**/.test.; the
buildscript uses it for the published dist/.Verified:
pnpm buildemits 0 test artifacts into dist/ (was 12) andnpm pack --dry-runships zero test files;pnpm build-js-clientstillemits its test files into js-dist/ so that CI job is unaffected.