fix: disable gRPC retries by default#277
Open
ivanauth wants to merge 4 commits into
Open
Conversation
…nts (authzed#200) Move grpc.enable_retries before ...options so callers can re-enable retries, and pass this.options (which carries the setting) to the preconnected clients instead of the raw options, so the default actually applies to the default PermissionsService client.
…#200) Uses grpc-js channelFactoryOverride to capture the final merged channel options. Verified discriminating: fails against the pre-fix v1.ts (enable_retries undefined), passes with the fix (0), and the override case yields 1.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #200.
Disables gRPC client retries by default - the grpc retries fail unrecoverably (
RST_STREAM code 0) through envoy/istio (#112). Overridable via{ "grpc.enable_retries": 1 }.Also passes the merged options to preconnected clients (not the raw arg), so the default reaches them; as a side effect they now get the default 30s deadline that lazy clients already had.
Mitigation, not a proven fix for #112 (not reproducible locally). Adds a unit test asserting the default + override.