fix: em-dashes, stale piranha endpoints, verify NVIDIA attribution in implementer guide#65
Merged
Conversation
…n in implementer guide
Fix 1: removed all 7 em-dashes (title, 3 pattern headings, 2 crosswalk
bullets, closing "submit a crosswalk PR" line) -- reworded each
sentence rather than swapping in a different dash character. Grep
confirmed 7 matched the brief's stated minimum exactly, no additional
instances found.
Fix 2/3: repointed Pattern 1's endpoint (prose + Python example) and
Pattern 3's SARIF example from api.piranha.bawbel.io/ave/{ave_id} to
api.aveproject.org/records/{ave_id} -- not just a domain swap, the
path segment changes too (records, not ave). Could not confirm this
against ave-api's live routes as the brief asked: that repo has no
code yet (just LICENSE and README), so applied the path per the
already-established records/ naming convention used elsewhere
(dist/ave-records-latest.json, etc.) rather than against a running
service.
Fix 4: verified NVIDIA SkillSpector attribution via web search --
github.com/nvidia/skillspector confirms this is a real NVIDIA project.
Left the attribution as-is; only the em-dash around it changed.
Noted, not fixed (out of this brief's stated scope): Pattern 1's
prose still says "optionally calls the PiranhaDB API" one line above
the now-aveproject.org-branded endpoint -- a Bawbel product name
sitting next to a standard-branded URL. Flagging for a follow-up
rather than bundling an unrequested fifth fix into this pass.
Validation: grep -c em-dash -> 0, grep piranha -> 0 results.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix 1 -- removed all 7 em-dashes: title, 3 pattern headings, 2 crosswalk bullets, closing "submit a crosswalk PR" line. Reworded each sentence rather than swapping in a different dash character. Confirmed via grep this was the full inventory, not just the brief's listed minimum.
Fix 2/3 -- repointed Pattern 1's endpoint (prose + Python example) and Pattern 3's SARIF example from `api.piranha.bawbel.io/ave/{ave_id}` to `api.aveproject.org/records/{ave_id}`. Not just a domain swap -- the path segment changes too. Could not confirm against `ave-api`'s live routes as the brief asked: that repo has no code yet (just `LICENSE` and `README.md`), so applied the path per the `records/` naming convention already established elsewhere in this repo (`dist/ave-records-latest.json`, etc.).
Fix 4 -- verified the NVIDIA SkillSpector attribution via web search: `github.com/nvidia/skillspector` confirms this is a real NVIDIA project. Left the attribution as-is; only the em-dash around it changed.
Noted, not fixed (out of this brief's stated scope): Pattern 1's prose still says "optionally calls the PiranhaDB API" one line above the now-`aveproject.org`-branded endpoint -- a Bawbel product name sitting next to a standard-branded URL. Flagging for a follow-up rather than bundling an unrequested fifth fix into this pass.
Test plan