-
Notifications
You must be signed in to change notification settings - Fork 18
chore(lint): Enable Pyflakes rules across all packages #497
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -22,7 +22,7 @@ target-version = "py311" | |
|
|
||
| [tool.ruff.lint] | ||
| preview = true | ||
| select = ["TID252"] # Enforce absolute imports (ban relative imports) | ||
| select = ["F", "TID252"] # Pyflakes (unused imports, undefined names, etc.) + absolute imports | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Unused imports in Python might be actually used because the imported symbols may not be used in the current module, instead be used by other modules importing this module
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Hmm I relied on tests to verfify this, I found one variable which was used at runtime, but no other issues. |
||
|
|
||
| [tool.ruff.lint.isort] | ||
| known-first-party = ["aws_durable_execution_sdk_python"] | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,6 +1,5 @@ | ||
| """Tests for create_callback_serdes.""" | ||
|
|
||
| import json | ||
| from datetime import datetime, timezone | ||
|
|
||
| import pytest | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,6 +1,5 @@ | ||
| """Tests for wait_for_callback_serdes.""" | ||
|
|
||
| import json | ||
| from datetime import datetime, timezone | ||
|
|
||
| import pytest | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -2,7 +2,6 @@ | |
|
|
||
| from __future__ import annotations | ||
|
|
||
| import datetime | ||
| import json | ||
| from unittest.mock import Mock, patch | ||
|
|
||
|
|
||
Uh oh!
There was an error while loading. Please reload this page.