Skip to content

ci: add log retention to example Lambdas#528

Open
zhongkechen wants to merge 1 commit into
mainfrom
codex/integration-log-retention
Open

ci: add log retention to example Lambdas#528
zhongkechen wants to merge 1 commit into
mainfrom
codex/integration-log-retention

Conversation

@zhongkechen

@zhongkechen zhongkechen commented Jul 10, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Summary

  • Generate AWS::Logs::LogGroup resources for example Lambda functions with 7 days retention
  • Add one-time cleanup before SAM deploy so existing unmanaged Lambda log groups do not block CloudFormation ownership
  • Cover template generation and cleanup behavior with focused tests

Testing

  • hatch run dev-examples:python -m pytest packages/aws-durable-execution-sdk-python-examples/test/test_log_group_deployment.py
  • python3 packages/aws-durable-execution-sdk-python-examples/scripts/generate_sam_template.py --output /tmp/python-durable-template.generated.json
  • python3 packages/aws-durable-execution-sdk-python-examples/scripts/cleanup_unmanaged_log_groups.py --help

Test runs of the updated workflow succeeded:

https://github.com/aws/aws-durable-execution-sdk-python/actions/runs/29116976186/job/86443766917?pr=528

image

@zhongkechen zhongkechen force-pushed the codex/integration-log-retention branch from 17334e7 to 57f97e9 Compare July 10, 2026 19:15
@zhongkechen zhongkechen changed the title Deploy example log groups with 7 day retention ci: add log retention to example Lambdas Jul 10, 2026
@zhongkechen zhongkechen self-assigned this Jul 10, 2026
@zhongkechen zhongkechen marked this pull request as ready for review July 10, 2026 19:26
@zhongkechen

zhongkechen commented Jul 10, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

some cases failed due to #520

https://github.com/aws/aws-durable-execution-sdk-python/actions/runs/29117388522/job/86444068706?pr=528

@zhongkechen zhongkechen requested a review from a team July 10, 2026 19:32
yaythomas
yaythomas previously approved these changes Jul 10, 2026
View reviewed changes

@yaythomas yaythomas left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@zhongkechen zhongkechen force-pushed the codex/integration-log-retention branch from 57f97e9 to 78ce842 Compare July 10, 2026 20:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yaythomas yaythomas yaythomas left review comments

At least 1 approving review is required to merge this pull request.

Assignees

@zhongkechen zhongkechen

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@zhongkechen @yaythomas