Skip to content

Add SDK version to IoT Metrics#690

Open
rakshil14-2 wants to merge 13 commits into
mainfrom
metrics_improvement
Open

Add SDK version to IoT Metrics#690
rakshil14-2 wants to merge 13 commits into
mainfrom
metrics_improvement

Conversation

@rakshil14-2

@rakshil14-2 rakshil14-2 commented Jun 8, 2026

Copy link
Copy Markdown
Contributor

Issue #, if available:

Description of changes:

  • Adding IoTSDKVersion to metrics and then passing it to CRT layer
  • Adding flags to disable the metrics. Using opt-out method (default false).
  • Separating Metrics field from username (removing old metrics).

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@rakshil14-2
rakshil14-2 force-pushed the metrics_improvement branch from 1dae97e to 77ff444 Compare June 16, 2026 20:46
@rakshil14-2 rakshil14-2 changed the title sdk layer metrics features Add SDK version to IoT Metrics Jun 16, 2026

@xiazhvera xiazhvera left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR looks good, but we definitely should add the same Android identifier to aws-crt-java, and make sure it passed the Android test.

Comment thread sdk/src/main/java/software/amazon/awssdk/iot/IoTSdkMetrics.java Outdated
Comment thread sdk/src/main/java/software/amazon/awssdk/iot/IoTSdkMetrics.java Outdated
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants