Skip to content

Wire in acquireAsync in adaptive strat#7166

Open
dagnir wants to merge 2 commits into
feature/master/adaptive-retries-fixesfrom
dongie/adaptive-fix-pt3
Open

Wire in acquireAsync in adaptive strat#7166
dagnir wants to merge 2 commits into
feature/master/adaptive-retries-fixesfrom
dongie/adaptive-fix-pt3

Conversation

@dagnir

@dagnir dagnir commented Jul 20, 2026

Copy link
Copy Markdown
Contributor

Motivation and Context

Fix adaptive retries incorrect rate limiting.

Modifications

Implement DefaultAdaptiveRetryStrategy's acquireInitialTokenAsync and refreshRetryTokenAsync using the new
RateLimiterTokenBucket#acquireAsync. The existing acquireInitialToken and refreshRetryToken delegate to these new methods.

Testing

Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Checklist

  • I have read the CONTRIBUTING document
  • Local run of mvn install succeeds
  • My code follows the code style of this project
  • My change requires a change to the Javadoc documentation
  • I have updated the Javadoc documentation accordingly
  • I have added tests to cover my changes
  • All new and existing tests passed
  • I have added a changelog entry. Adding a new entry must be accomplished by running the scripts/new-change script and following the instructions. Commit the new file created by the script in .changes/next-release with your changes.
  • My change is to implement 1.11 parity feature and I have updated LaunchChangelog

License

  • I confirm that this pull request can be released under the Apache 2 license

@dagnir
dagnir marked this pull request as ready for review July 20, 2026 21:50
@dagnir
dagnir requested a review from a team as a code owner July 20, 2026 21:50
Implement `DefaultAdaptiveRetryStrategy`'s `acquireInitialTokenAsync`
and `refreshRetryTokenAsync` using the new
`RateLimiterTokenBucket#acquireAsync`. The existing
`acquireInitialToken` and `refreshRetryToken` delegate to these new
methods.
@dagnir
dagnir force-pushed the dongie/adaptive-fix-pt3 branch from a1c0343 to 7556f5b Compare July 20, 2026 21:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants