Conversation
azkrishpy
commented
Jul 22, 2026
| architecture: ${{ matrix.arch }} | ||
| - uses: ilammy/setup-nasm@v1 | ||
| with: | ||
| version: '3.02rc8' |
Contributor
Author
There was a problem hiding this comment.
should we use a tagged release or the oldest release with the fix? I don't have particular opinions on this.
Contributor
Author
|
the asm file will be fixed on aws-lc |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
nasm's Codeview debug-info backend (output/codeview.c) panics when it's asked to emit debug tables (-g flag, which the failing CI command uses) for an object with no code section — which is exactly what aesni-xts-avx512.asm produces on win64 when MY_ASSEMBLER_IS_TOO_OLD_FOR_512AVX is defined.
This issue was observed since aws/aws-lc#3319 which optimizes avx512 out when OPENSSL_SMALL is set (which we do by default).
Description of changes:
Bumped to the oldest version that actually fixes this issue.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.