Skip to content

docs(agents): fix new-item-type agent to require command_support.yaml review and prohibit VCR cassette creation - #86

Draft
ayeshurun with Copilot wants to merge 9 commits into
mainfrom
copilot/update-new-item-type-agent-md
Draft

docs(agents): fix new-item-type agent to require command_support.yaml review and prohibit VCR cassette creation#86
ayeshurun with Copilot wants to merge 9 commits into
mainfrom
copilot/update-new-item-type-agent-md

Conversation

Copilot AI commented Mar 23, 2026

Copy link
Copy Markdown

📥 Pull Request

✨ Description of new changes

PR #85 (SnowflakeDatabase onboarding) exposed two gaps in the new-item-type.agent.md instructions: the agent skipped command_support.yaml entirely for simple items, and fabricated 14 VCR cassette recording files.

Step 10 (command_support.yaml)

  • Added sub-step 10a: review unsupported_items lists for rm, get, set, mkdir -- applies to all item types, not just those with definitions
  • Reorganized existing export/import/mv/cp guidance as sub-steps 10b-10e
  • All complexity patterns (Simple, Creation Params, OneLake Folders, Job Support) now reference Step 10
  • Verification table changed from "Has definitions" to "Always"

Step 11 (test parametrization)

  • Explicit prohibition: do not create VCR cassette files under tests/test_commands/recordings/. Only modify parametrization lists in conftest.py. Recordings are generated from live test runs.

ayeshurun and others added 7 commits March 17, 2026 12:14
This script benchmarks the startup performance of the CLI by measuring module import times, CLI invocation times, and heavy dependency loading. It allows comparisons against a baseline branch or tag.
…all item types, prohibit creating VCR cassettes

Co-authored-by: ayeshurun <98805507+ayeshurun@users.noreply.github.com>
Agent-Logs-Url: https://github.com/ayeshurun/fabric-cli/sessions/c94f523e-ee18-4151-9b8f-e8cb2e27e41b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants