feat: add --feature_flags argument to deploy command - #89
Open
ayeshurun wants to merge 2 commits into
Open
Conversation
Replaces the unreleased --bulk_publish flag with a general --feature_flags argument that enables arbitrary fabric-cicd feature flags via a single comma-separated value. Flag names are validated against fabric-cicd's supported feature flag list (falling back to the FeatureFlag enum on older releases). enable_experimental_features and disable_print_identity are always enabled by the CLI and skipped if the user passes them explicitly. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: c5eedf4e-9a35-4fab-8788-7b793f4fd160
Drops the get_supported_feature_flags() import with ImportError fallback in favor of deriving VALID_FEATURE_FLAGS directly from the fabric-cicd FeatureFlag enum. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: c5eedf4e-9a35-4fab-8788-7b793f4fd160
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📥 Pull Request
✨ Description of new changes
Summary: Adds a
--feature_flagsargument tofab deploythat enables fabric-cicd feature flags via a single comma-separated value:This replaces the never-released
--bulk_publishflag (microsoft#260) with a general-purpose mechanism, so the CLI surface stays stable as fabric-cicd adds new flags.Context:
FeatureFlagenum; unknown names raiseERROR_INVALID_INPUTlisting the valid flags.enable_experimental_features(gate for experimental flags) anddisable_print_identity(keeps identity info out of logs) are always enabled, and skipped if the user passes them explicitly.Also removes the obsolete
--bulk_publishcode, docs, tests, and changie entry, and updates docs plus unit and e2e tests. mypy is clean; all deploy tests pass.Dependencies: None.