Skip to content

Preserve ambiguous ID forms - #376

Merged
bartekplus merged 1 commit into
masterfrom
codex/preserve-ambiguous-id
Aug 8, 2026
Merged

Preserve ambiguous ID forms#376
bartekplus merged 1 commit into
masterfrom
codex/preserve-ambiguous-id

Conversation

@bartekplus

Copy link
Copy Markdown
Owner

Summary

  • preserve ID, Id, and id exactly as typed
  • remove the ambiguous idi'd contraction mapping while keeping unambiguous contraction normalization
  • add unit and browser-level regression coverage and update the E2E coverage matrix

Root cause

The English contraction rule performed a case-insensitive lookup of id and then reapplied the input's case pattern. As a result, the valid initialism ID was rewritten to I'D by a default-enabled safe rule.

Because all casing forms of id are valid and contextually ambiguous, this change preserves them rather than guessing. Explicit i'd input is still capitalized to I'd by the existing pronoun-capitalization rule.

Follow-up to #365.

Validation

  • bun run check
  • bun run test — 1,562 passed
  • bun run check:e2e:coverage
  • bun run test:e2e — Chrome: 26 passed
  • bun run test:e2e --platform=firefox — 26 passed
  • bun run test:e2e:full — Chrome: 65 passed, 7 expected skips
  • bun run test:e2e:full --platform=firefox — 65 passed, 7 expected skips

@bartekplus
bartekplus marked this pull request as ready for review August 8, 2026 08:04
@bartekplus
bartekplus merged commit 48887ce into master Aug 8, 2026
8 checks passed
@bartekplus
bartekplus deleted the codex/preserve-ambiguous-id branch August 8, 2026 08:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant