Preserve ambiguous ID forms - #376
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ID,Id, andidexactly as typedid→i'dcontraction mapping while keeping unambiguous contraction normalizationRoot cause
The English contraction rule performed a case-insensitive lookup of
idand then reapplied the input's case pattern. As a result, the valid initialismIDwas rewritten toI'Dby a default-enabled safe rule.Because all casing forms of
idare valid and contextually ambiguous, this change preserves them rather than guessing. Expliciti'dinput is still capitalized toI'dby the existing pronoun-capitalization rule.Follow-up to #365.
Validation
bun run checkbun run test— 1,562 passedbun run check:e2e:coveragebun run test:e2e— Chrome: 26 passedbun run test:e2e --platform=firefox— 26 passedbun run test:e2e:full— Chrome: 65 passed, 7 expected skipsbun run test:e2e:full --platform=firefox— 65 passed, 7 expected skips