ConfiguredTargetFactory: let analysis_test impls run when deps have AnalysisFailureInfo - #30503
Open
alex-torok wants to merge 1 commit into
Open
Conversation
…nalysisFailureInfo When --allow_analysis_failures=true is set globally, ConfiguredTargetFactory short-circuited the rule impl for any rule whose deps had AnalysisFailureInfo. This broke analysis_test=True rules: their impl never ran, so no AnalysisTestResultInfo was returned, and the build errored with: "rules with analysis_test=true must return an instance of AnalysisTestResultInfo" analysis_test rules exist specifically to inspect dep analysis failures. The short-circuit is correct for ordinary rules that should propagate failures upward, but wrong for analysis_test rules whose impl is the intended consumer of AnalysisFailureInfo. The fix adds a narrow guard: skip the short-circuit when the rule is an analysis_test. This allows bazel_skylib's analysistest.make(expect_failure=True) to work correctly even when --allow_analysis_failures is also set globally.
github-actions
Bot
added
team-Configurability
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
When --allow_analysis_failures=true is set globally, ConfiguredTargetFactory short-circuited the rule impl for any rule whose deps had AnalysisFailureInfo. This broke analysis_test=True rules: their impl never ran, so no AnalysisTestResultInfo was returned, and the build errored with:
"rules with analysis_test=true must return an instance of AnalysisTestResultInfo"
analysis_test rules exist specifically to inspect dep analysis failures. The short-circuit is correct for ordinary rules that should propagate failures upward, but wrong for analysis_test rules whose impl is the intended consumer of AnalysisFailureInfo.
The fix adds a narrow guard: skip the short-circuit when the rule is an analysis_test. This allows bazel_skylib's analysistest.make(expect_failure=True) to work correctly even when --allow_analysis_failures is also set globally.
Motivation
Fixes #30500
Build API Changes
No
Checklist
Release Notes
RELNOTES: None