Pass use_pic when creating module codegen actions - #788
Closed
fmeum wants to merge 1 commit into
Closed
Conversation
Module codegen actions compile a module file into an object file. _create_module_codegen_action computes use_pic from the module file's name but didn't forward it to the created compile action, so Bazel treats the action as non-PIC even for PIC module files and e.g. looks up the non-PIC transitive modules as inputs, which are empty in PIC-only builds.
fmeum
force-pushed
the
module-codegen-inputs
branch
from
July 17, 2026 16:06
9725e21 to
f249d3f
Compare
fmeum
changed the title
fmeum
marked this pull request as ready for review
July 17, 2026 16:07
trybka
approved these changes
Jul 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Module codegen actions (
header_module_codegen) compile a module file into an object file._create_module_codegen_actioncomputesuse_picfrom the module file's name but didn't forward it to_create_compile_action, so Bazel'sCppCompileActionBuildertreats the action as non-PIC even for PIC module files — and e.g. looks up the non-PIC transitive modules as mandatory inputs, which are empty in PIC-only builds.