Automatically add supports-path-mapping where applicable - #803
Conversation
This way users don't have to pass: ``` --modify_execution_info=CppCompile=+supports-path-mapping,CppModuleMap=+supports-path-mapping,CppArchive=+supports-path-mapping ``` or know which mnemonics support it. This still does nothing unless the overall path stripping feature is enabled
|
I think we need a feature flag for this, based on our findings with CppLink there's probably toolchains that break with it. |
|
what's an example of a toolchain specific breakage? |
|
I thought your finding was that this broke on apple?
|
|
that's only a problem with CppLink |
|
To clarify my previous statement: |
|
are you enabling this globally with --modify_execution_info today? i imagine there's a lot more value in flipping that for CppCompile than for CppLink, since there are a lot more potential actions to dedup. Also note this PR isn't doing CppCompile because that has to be done in java still bazelbuild/bazel#30485 |
|
CppCompile and CppModuleMap (at least internally, maybe their behavior diverges externally) also need to share the same modify_execution_info state. |
|
More accurately, most of my testing had --modify_execution_info='CppCompile|CppModuleMap|CppCompileHeader=+supports-path-mapping' |
This way users don't have to pass:
or know which mnemonics support it. This still does nothing unless the
overall path stripping feature is enabled