pkg_files: avoid index-out-of-range error (#1070)#1071
Closed
grrtrr wants to merge 1 commit into
Closed
Conversation
Under the (possible) conditions in bazelbuild#1070, `add_from_default_info()` fails with: ```console File "/home/grenker/.cache/bazel/_bazel_grenker/d2508ebd25597e9a92cadc5f3ae02937/external/rules_pkg/pkg/private/tar/tar.bzl", line 136, column 19, in _pkg_tar_impl add_label_list(mapping_context, srcs = ctx.attr.srcs) File "/home/grenker/.cache/bazel/_bazel_grenker/d2508ebd25597e9a92cadc5f3ae02937/external/rules_pkg/pkg/private/pkg_files.bzl", line 373, column 34, in add_label_list add_from_default_info( File "/home/grenker/.cache/bazel/_bazel_grenker/d2508ebd25597e9a92cadc5f3ae02937/external/rules_pkg/pkg/private/pkg_files.bzl", line 440, column 52, in add_from_default_info base_file = the_executable or all_files[0] Error: index out of range (index is 0, but sequence has 0 elements) ``` Avoid this condition by returning early. Resolves bazelbuild#1070.
cgrindel
approved these changes
Jul 12, 2026
Author
|
Already resolved by 5449272. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Under the (possible) conditions in #1070,
add_from_default_info()fails with:Avoid this condition by returning early. Resolves #1070.