Read the full stream in FileUtils.imageToBase64ByStream#4057
Open
vasiliy-mikhailov wants to merge 1 commit into
Open
Read the full stream in FileUtils.imageToBase64ByStream#4057vasiliy-mikhailov wants to merge 1 commit into
vasiliy-mikhailov wants to merge 1 commit into
Conversation
The method sized its buffer from in.available() (only an estimate, not the total) and called in.read(data) once while ignoring the returned count, so any stream that does not return all bytes in a single read (buffered/network streams) left the buffer partially filled with trailing zeros, producing truncated/corrupted base64. Read the stream fully via IOUtils.toByteArray (commons-io, already imported). Fills the existing empty testImageToBase64ByStream with a regression test.
Owner
|
@codex augiee review |
|
Codex Review: Didn't find any major issues. What shall we delve into next? Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
imageToBase64ByStreamsizes its buffer fromin.available()— only an estimate of the bytes immediately available, not the total — and then callsin.read(data)once, ignoring the returned count. Any stream that does not return all its bytes in a singleread(buffered or network-backed streams are the common case) leaves the buffer partially filled with trailing zero bytes, producing a truncated/corrupted base64 string.This reads the stream fully via
IOUtils.toByteArray(in)(commons-io, already imported and used elsewhere in this file). Fills the previously-emptytestImageToBase64ByStreamwith a regression test using a stream that returns at most 16 bytes perread— it fails before the change (truncated output) and passes after.