Skip to content

Bump Expo version in integration tests #13

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ofalvai wants to merge 1 commit into
base: master
Choose a base branch
from
+5 −12
Open

Bump Expo version in integration tests #13

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions .github/workflows/ci-test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,7 @@ jobs:
needs: lint
runs-on: bitrise-react-native-code-push-linux-runner
strategy:
fail-fast: false
matrix:
variant: [bare, expo]
include:
Expand Down Expand Up @@ -64,6 +65,7 @@ jobs:
needs: lint
runs-on: bitrise-react-native-code-push-macos-runner
strategy:
fail-fast: false
matrix:
variant: [bare, expo]
include:
Expand Down
4 changes: 2 additions & 2 deletions code-push-plugin-testing-framework/script/testBuilder.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,9 +62,9 @@ function getDescribe() {
}
function itInternal(func, expectation, isCoreTest, assertion) {
if ((!TestConfig.onlyRunCoreTests || isCoreTest)) {
// Create a wrapper around the assertion to set the timeout on the test to 10 minutes.
// DIAGNOSTIC: temporarily shortened from 20 minutes to get faster CI feedback while debugging PR #13's iOS Expo test hang. Revert before merging.
var assertionWithTimeout = function (done) {
this.timeout(10 * 2 * 60 * 1000);
this.timeout(6 * 60 * 1000);
assertion(done);
};
return it(expectation, assertionWithTimeout);
Expand Down
8 changes: 0 additions & 8 deletions test/template/app.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,14 +26,6 @@
"CodePushServerURL": "http://10.0.2.2:3001"
}
}
],
[
"expo-build-properties",
{
"ios": {
"deploymentTarget": "15.5"
}
}
]
]
}
Expand Down
3 changes: 1 addition & 2 deletions test/test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -366,12 +366,11 @@ class RNProjectManager extends ProjectManager {
mkdirp.sync(projectDirectory);

if (TestConfig.isExpoApp) {
return TestUtil.getProcessOutput(`npx create-expo-app@latest ${appName} --template blank@sdk-55`, { cwd: projectDirectory, timeout: 30 * 60 * 1000 })
return TestUtil.getProcessOutput(`npx create-expo-app@latest ${appName} --template blank@sdk-57`, { cwd: projectDirectory, timeout: 30 * 60 * 1000 })
.then((e) => { console.log(`"npx expo init ${appName}" success. cwd=${projectDirectory}`); return e; })
.then(this.copyTemplate.bind(this, templatePath, projectDirectory))
.then<void>(TestUtil.getProcessOutput.bind(undefined, TestConfig.thisPluginInstallString, { cwd: path.join(projectDirectory, TestConfig.TestAppName) }))
.then(installExpoBundleTooling.bind(undefined, path.join(projectDirectory, TestConfig.TestAppName)))
.then<void>(TestUtil.getProcessOutput.bind(undefined, "npx expo install expo-build-properties", { cwd: path.join(projectDirectory, TestConfig.TestAppName) }))
.then(TestUtil.getProcessOutput.bind(undefined, `npx expo prebuild --clean`, { cwd: path.join(projectDirectory, TestConfig.TestAppName) }))
.then(() => {
ensureAndroidCleartextTraffic(path.join(projectDirectory, TestConfig.TestAppName, "android", "app", "src", "main", "AndroidManifest.xml"));
Expand Down
Loading