Gate channel tasks experiment#1275
Conversation
klopez4212
force-pushed
the
kennylopez-agent-thread-continuous-conversations
branch
2 times, most recently
from
f727a44 to
f45c44f
Compare
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: f45c44f52b
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: cf5fc6687c
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 9b99ec19a0
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
klopez4212
force-pushed
the
kennylopez-agent-thread-continuous-conversations
branch
from
9b99ec1 to
69de848
Compare
klopez4212
changed the title
💡 Codex Review Preserve channel unread badges while a task is open
When a task conversation is selected, this drops the entire source channel from the unread ID set based only on the channel id. In the scenario where that channel also has unrelated unread messages, the task screen only marks the task thread messages read, so deleting the channel here hides the sidebar badge/overflow indicator for real unread content until the user leaves the task. Keep the channel unread state visible, or subtract only the task thread’s messages rather than suppressing the whole channel. Scroll to the agent reply from task rows
For markers whose agent reply is inside a thread ( ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
There was a problem hiding this comment.
💡 Codex Review
buzz/desktop/src/features/channels/ui/ChannelPane.tsx
Lines 572 to 574 in 7570128
Target the reply when opening task messages
When a task was started from a reply (marker.parentMessageId is set), the Tasks tab's “Go to message” path opens only threadMessage and returns without setting any scroll/highlight target for the actual task reply. In long threads this lands at the thread head/default position rather than the source reply the button promises to show; route through the existing deep-link target logic or propagate message.id as the thread scroll target after opening the thread.
Build scroll indexes with the same day-divider option
When showInitialDayDivider is false (as in the agent conversation screen), the child list omits the initial divider, but this parent timelineItems call still uses the default that includes it. That makes virtualizerOption.itemCount and indexByMessageId one row larger than the rendered TimelineMessageList, so bottom pinning or target convergence can scroll to the wrong/out-of-range index; pass showInitialDayDivider into this buildTimelineItems call and include it in the deps.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
klopez4212
force-pushed
the
kennylopez-agent-tasks-links
branch
from
1c25994 to
0b25615
Compare
klopez4212
force-pushed
the
kennylopez-agent-thread-continuous-conversations
branch
from
7570128 to
f07ffd3
Compare
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: f07ffd394e
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
klopez4212
force-pushed
the
kennylopez-agent-tasks-links
branch
from
0b25615 to
49cdaf8
Compare
klopez4212
force-pushed
the
kennylopez-agent-thread-continuous-conversations
branch
from
f07ffd3 to
6490e73
Compare
klopez4212
force-pushed
the
kennylopez-agent-tasks-links
branch
from
49cdaf8 to
846fab4
Compare
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 6490e73e7b
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
klopez4212
force-pushed
the
kennylopez-agent-thread-continuous-conversations
branch
2 times, most recently
from
094a9f7 to
090eff6
Compare
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 090eff61e5
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
klopez4212
force-pushed
the
kennylopez-agent-tasks-links
branch
from
a99845a to
a0d386a
Compare
klopez4212
force-pushed
the
kennylopez-agent-thread-continuous-conversations
branch
2 times, most recently
from
210c44e to
7f05400
Compare
klopez4212
force-pushed
the
kennylopez-agent-tasks-links
branch
from
239d19e to
ea173d7
Compare
klopez4212
force-pushed
the
kennylopez-agent-thread-continuous-conversations
branch
from
7f05400 to
7d4dba1
Compare
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 7d4dba1820
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
klopez4212
force-pushed
the
kennylopez-agent-tasks-channel-ui
branch
from
78676e5 to
7ef655f
Compare
klopez4212
force-pushed
the
kennylopez-agent-thread-continuous-conversations
branch
from
a6d69f4 to
6b0949a
Compare
klopez4212
force-pushed
the
kennylopez-agent-tasks-channel-ui
branch
from
7ef655f to
f6bcac3
Compare
klopez4212
force-pushed
the
kennylopez-agent-thread-continuous-conversations
branch
from
6b0949a to
71ff880
Compare
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 5a3afcad61
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: fb8862baa1
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 5e28bde927
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| if (!marker.agentPubkey) { | ||
| continue; | ||
| } | ||
| if (!anchorMessage || anchorIndex === undefined) { | ||
| const hasLoadedThreadContext = orderedMessages.some(({ message }) => { |
There was a problem hiding this comment.
When a task was started from a human source message that mentioned an agent, the marker still has agentPubkey even though the anchor is not authored by that agent. Fresh evidence beyond the earlier source-anchor fix is that this missing-anchor path treats any marker with an agent pubkey as a cutoff candidate; the anchorMessage.pubkey !== marker.agentPubkey guard only runs when the anchor is loaded. If the human anchor is outside the current history window but the root/later replies are loaded, normal thread replies after startedAt get hidden from the Messages view/thread.
Useful? React with 👍 / 👎.
| const agentLookupReady = | ||
| !channelMembersQuery.isLoading && | ||
| !managedAgentsQuery.isLoading && | ||
| messageProfilesReady && | ||
| !relayAgentsQuery.isLoading; |
There was a problem hiding this comment.
When the channel members, managed agents, or relay agents queries are refetching with stale cached data, isLoading is already false, so this can mark agent lookup ready before the refreshed agent list arrives. In that window, clicking New task on a message whose routeable agent is only in the in-flight lookup falls through with taskAgent === null instead of queuing, opening/publishing a task with empty agent fields and causing plain follow-ups to miss the intended agent p tag. Use the settled/pending signal that also accounts for isFetching before allowing the empty-agent fallback.
Useful? React with 👍 / 👎.
1 participant
Summary
channel-tasksExperiments flag.Stack
Snapshots
Task marker and recap
Channel Tasks tab
Tests
git diff --check origin/main..HEADcd desktop && pnpm check:file-sizes && ./node_modules/.bin/tsc --noEmitcd desktop && pnpm testcargo test --manifest-path desktop/src-tauri/Cargo.toml deep_link --libcd desktop && pnpm exec playwright test tests/e2e/agent-task-snapshots.spec.ts --project=smoke --config playwright.config.tsusing a temporary local spec that was removed before commit.